-
Enhancement
-
Resolution: Duplicate
-
P3
-
9
From Magnus' review mail:
* This code that previously was in jdk/make/CopyIntoClasses has now unfortunately moved this very specific logic up into the top repo. In fact, the top/make/CompileJavaModules.gmk now contain module-specific data such as "java.base_COPY := .icu .dat .spp content-types.properties". This should really be split into module-specific files and pushed down once again to the jdk/make directory, maybe into the copy directory.
I agree that there is a lot of module specific information collected in one big file in the root repo. This should ideally be moved closer to each module.
* This code that previously was in jdk/make/CopyIntoClasses has now unfortunately moved this very specific logic up into the top repo. In fact, the top/make/CompileJavaModules.gmk now contain module-specific data such as "java.base_COPY := .icu .dat .spp content-types.properties". This should really be split into module-specific files and pushed down once again to the jdk/make directory, maybe into the copy directory.
I agree that there is a lot of module specific information collected in one big file in the root repo. This should ideally be moved closer to each module.
- duplicates
-
JDK-8258407 Split up CompileJavaModules.gmk into make/modules/$M/Java.gmk
-
- Resolved
-
- relates to
-
JDK-8244044 Refactor phase makefiles to be structured per module
-
- Resolved
-