Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8057799

G1: Unnecessary NULL check in G1KeepAliveClosure

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved
    • P4
    • Resolution: Fixed
    • None
    • 9
    • hotspot
    • gc
    • b33

    Backports

      Description

        The null check in the following code is not necessary:

        class G1KeepAliveClosure: public OopClosure {
          ...
          void do_oop(oop* p) {
            oop obj = *p;

            G1CollectedHeap::in_cset_state_t cset_state = _g1->in_cset_state(obj);
            if (obj == NULL || cset_state == G1CollectedHeap::InNeither) {
              return;
            }

        As Thomas pointed out, G1KeepAliveClosure is only called from JNIHandleBlock::weak_oops_do which already filters out NULL values.

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8058097 G1: Unnecessary NULL check in G1KeepAliveClosure

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8063328 G1: Unnecessary NULL check in G1KeepAliveClosure

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8071064 G1: Unnecessary NULL check in G1KeepAliveClosure

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8083409 G1: Unnecessary NULL check in G1KeepAliveClosure

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Activity

              People

                tonyp Tony Printezis
                tonyp Tony Printezis
                Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: