| Issue | Fix Version | Assignee | Priority | Status | Resolution | Resolved In Build |
|---|---|---|---|---|---|---|
| JDK-8083409 | emb-9 | Tony Printezis | P4 | Resolved | Fixed | b33 |
| JDK-8063328 | 8u45 | Tony Printezis | P4 | Resolved | Fixed | b01 |
| JDK-8058097 | 8u40 | Thomas Schatzl | P4 | Resolved | Fixed | b09 |
| JDK-8071064 | emb-8u47 | Tony Printezis | P4 | Resolved | Fixed | team |
The null check in the following code is not necessary:
class G1KeepAliveClosure: public OopClosure {
...
void do_oop(oop* p) {
oop obj = *p;
G1CollectedHeap::in_cset_state_t cset_state = _g1->in_cset_state(obj);
if (obj == NULL || cset_state == G1CollectedHeap::InNeither) {
return;
}
As Thomas pointed out, G1KeepAliveClosure is only called from JNIHandleBlock::weak_oops_do which already filters out NULL values.
class G1KeepAliveClosure: public OopClosure {
...
void do_oop(oop* p) {
oop obj = *p;
G1CollectedHeap::in_cset_state_t cset_state = _g1->in_cset_state(obj);
if (obj == NULL || cset_state == G1CollectedHeap::InNeither) {
return;
}
As Thomas pointed out, G1KeepAliveClosure is only called from JNIHandleBlock::weak_oops_do which already filters out NULL values.
- backported by
-
JDK-8058097 G1: Unnecessary NULL check in G1KeepAliveClosure
-
- Resolved
-
-
-
- Resolved
-
-
-
- Resolved
-
-
-
- Resolved
-