Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8057916

Sort includes and verify copyright for new files

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved
    • P4
    • Resolution: Fixed
    • 8u40
    • 9
    • hotspot
    • gc
    • b34

    Backports

      Description

        Some of the new files add by refactoring the gc code have introduced includes that are not correctly sorted. The includes should be sorted alphabetically but always with precompiled.hpp first, the other exception is that all includes guarded by defines should be placed after all other includes. For example:
        #include "precompiled.hpp"
        #include "prims/jni.h"
        #include "prims/whitebox.hpp"
        #include "utilities/debug.hpp"
        #if INCLUDE_ALL_GCS
        #include "gc_implementation/g1/g1AllocationContext.hpp"
        #include "gc_implementation/g1/g1CollectedHeap.inline.hpp"
        #include "gc_implementation/g1/heapRegion.hpp"
        #endif // INCLUDE_ALL_GCS

        Some of the new files also need to have the copyright text altered to be correct.

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8057924 Sort includes and verify copyright for new files

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8063587 Sort includes and verify copyright for new files

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8070704 Sort includes and verify copyright for new files

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8083559 Sort includes and verify copyright for new files

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Activity

              People

                sjohanss Stefan Johansson
                sjohanss Stefan Johansson
                Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: