Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8064580

Move INCLUDE_CDS include section to the end of the include list

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Fixed
    • Icon: P4 P4
    • 9
    • 9
    • hotspot
    • b42

        We should keep our conditional include statements at the end of the include lists. This ensures that utilities/macros.hpp is included before we use the INCLUDE_* defines. It's also consistent with how most of the includes are/were structured in HotSpot.

        This was recently added to the files section of the the StyleGuide document:
        https://wiki.openjdk.java.net/display/HotSpot/StyleGuide

        So, includes like this:
        #include "classfile/classLoaderData.inline.hpp"
        #include "classfile/defaultMethods.hpp"
        #include "classfile/javaClasses.hpp"
        #include "classfile/symbolTable.hpp"
        #include "classfile/systemDictionary.hpp"
        #if INCLUDE_CDS
        #include "classfile/systemDictionaryShared.hpp"
        #endif
        #include "classfile/verificationType.hpp"
        #include "classfile/verifier.hpp"
        #include "classfile/vmSymbols.hpp"
        #include "memory/allocation.hpp"
        #include "utilities/macros.hpp"

        should be changed to:
        #include "classfile/classLoaderData.inline.hpp"
        #include "classfile/defaultMethods.hpp"
        #include "classfile/javaClasses.hpp"
        #include "classfile/symbolTable.hpp"
        #include "classfile/systemDictionary.hpp"
        #include "classfile/verificationType.hpp"
        #include "classfile/verifier.hpp"
        #include "classfile/vmSymbols.hpp"
        #include "memory/allocation.hpp"
        #include "utilities/macros.hpp"
        #if INCLUDE_CDS
        #include "classfile/systemDictionaryShared.hpp"
        #endif

              stefank Stefan Karlsson
              stefank Stefan Karlsson
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: