Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8065422

Trailing dot in hostname causes TLS handshake to fail with SNI disabled

    XMLWordPrintable

Details

    • b09
    • x86
    • os_x
    • Verified

    Backports

      Description

        FULL PRODUCT VERSION :
        java version "1.8.0_25"
        Java(TM) SE Runtime Environment (build 1.8.0_25-b17)
        Java HotSpot(TM) 64-Bit Server VM (build 25.25-b02, mixed mode)

        ADDITIONAL OS VERSION INFORMATION :
        Mac OS X 10.10

        EXTRA RELEVANT SYSTEM CONFIGURATION :
        Tomcat 8.0.15
        vm args: -Djsse.enableSNIExtension=false

        A DESCRIPTION OF THE PROBLEM :
        Hi there,
        I’m running into an issue with fully-qualified domain names and https
        using Tomcat 8 and JDK 8.
        Tomcat version: 8.0.15
        JDK Version: 1.8.0_25
        OS: Mac OS X 10.10

        If you include the trailing dot in a request over https, the TLS handshake will fail. The client tries to fall back to SSLv3, but if you have SSLv3 disabled, the whole thing just fails.

        My SSL Connector looks like this:
        <Connector SSLEnabled="true" URIEncoding="UTF-8" acceptCount="100" clientAuth="false" debug="1"
        disableUploadTimeout="true" enableLookups="false" keystoreFile="../keystore.jks" keystorePass="password"
        maxHttpHeaderSize="8192" keyAlias="selfsigned" port="8443" protocol="org.apache.coyote.http11.Http11Protocol"
        scheme="https" secure="true" sslEnabledProtocols="TLSv1,TLSv1.1,TLSv1.2">


        https://localhost.:8443 in Chrome 38 returns
        ERR_SSL_VERSION_OR_CIPHER_MISMATCH.

        The output from javax.net.debug=all contains this for each TLS version handshake:
        http-bio-8443-exec-5, handling exception: javax.net.ssl.SSLProtocolException: Illegal server name, type=host_name(0), name=localhost., value=6c:6f:63:61:6c:68:6f:73:74:2e

        This looks like it’s being bubbled up from the SNIHostName constructor in Java 8 (https://docs.oracle.com/javase/8/docs/api/javax/net/ssl/SNIHostName.html),
        which explicitly forbids trailing dots in hostnames (valid hostname, but not a valid SNI hostname). I’m not using SNI, but to make sure I set jsse.enableSNIExtension=false. The exception is still thrown, leading me to believe that the SNIHostName constructor is being called whether SNI is enabled or not.


        Why not just remove the trailing dot? Well, it’s valid to be there, so why not support it. More importantly, we make use of this to get around TLS session caching as discussed here: https://developer.apple.com/library/ios/qa/qa1727/_index.html.


        This issue is not present in Tomcat 7 or using Java 7. I have a small PoC I can zip up and host somewhere if anyone wants to take a look.

        REGRESSION. Last worked in version 7u72

        STEPS TO FOLLOW TO REPRODUCE THE PROBLEM :
        1. Create Tomcat site using HTTPS JSSE connector
        2. Enable *only* TLS
        3. Visit site with trailing dot in FQDN (e.g. https://localhost.:8443)

        EXPECTED VERSUS ACTUAL BEHAVIOR :
        EXPECTED -
        Https handshake completes and site is served over https.
        Client may give certificate name mismatch error depending on implementation.
        ACTUAL -
        TLS handshake fails and client returns cipher mismatch when it tries to send SSLv3 ClientHello as fall-back.

        ERROR MESSAGES/STACK TRACES THAT OCCUR :
        http-bio-8443-exec-5, handling exception: javax.net.ssl.SSLProtocolException: Illegal server name, type=host_name(0), name=localhost., value=6c:6f:63:61:6c:68:6f:73:74:2e

        REPRODUCIBILITY :
        This bug can be reproduced always.

        ---------- BEGIN SOURCE ----------
        example server.xml:
        <?xml version="1.0" encoding="UTF-8"?>
        <!--
          Licensed to the Apache Software Foundation (ASF) under one or more
          contributor license agreements. See the NOTICE file distributed with
          this work for additional information regarding copyright ownership.
          The ASF licenses this file to You under the Apache License, Version 2.0
          (the "License"); you may not use this file except in compliance with
          the License. You may obtain a copy of the License at

              http://www.apache.org/licenses/LICENSE-2.0

          Unless required by applicable law or agreed to in writing, software
          distributed under the License is distributed on an "AS IS" BASIS,
          WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
          See the License for the specific language governing permissions and
          limitations under the License.
        --><!-- Note: A "Server" is not itself a "Container", so you may not
             define subcomponents such as "Valves" at this level.
             Documentation at /docs/config/server.html
         --><Server port="8005" shutdown="SHUTDOWN">
          <Listener className="org.apache.catalina.startup.VersionLoggerListener"/>
          <!-- Security listener. Documentation at /docs/config/listeners.html
          <Listener className="org.apache.catalina.security.SecurityListener" />
          -->
          <!--APR library loader. Documentation at /docs/apr.html -->
          <Listener SSLEngine="on" className="org.apache.catalina.core.AprLifecycleListener"/>
          <!-- Prevent memory leaks due to use of particular java/javax APIs-->
          <Listener className="org.apache.catalina.core.JreMemoryLeakPreventionListener"/>
          <Listener className="org.apache.catalina.mbeans.GlobalResourcesLifecycleListener"/>
          <Listener className="org.apache.catalina.core.ThreadLocalLeakPreventionListener"/>

          <!-- Global JNDI resources
               Documentation at /docs/jndi-resources-howto.html
          -->
          <GlobalNamingResources>
            <!-- Editable user database that can also be used by
                 UserDatabaseRealm to authenticate users
            -->
            <Resource auth="Container" description="User database that can be updated and saved" factory="org.apache.catalina.users.MemoryUserDatabaseFactory" name="UserDatabase" pathname="conf/tomcat-users.xml" type="org.apache.catalina.UserDatabase"/>
          </GlobalNamingResources>

          <!-- A "Service" is a collection of one or more "Connectors" that share
               a single "Container" Note: A "Service" is not itself a "Container",
               so you may not define subcomponents such as "Valves" at this level.
               Documentation at /docs/config/service.html
           -->
          <Service name="Catalina">

            <!--The connectors can use a shared executor, you can define one or more named thread pools-->
            <!--
            <Executor name="tomcatThreadPool" namePrefix="catalina-exec-"
                maxThreads="150" minSpareThreads="4"/>
            -->


            <!-- A "Connector" represents an endpoint by which requests are received
                 and responses are returned. Documentation at :
                 Java HTTP Connector: /docs/config/http.html (blocking & non-blocking)
                 Java AJP Connector: /docs/config/ajp.html
                 APR (HTTP/AJP) Connector: /docs/apr.html
                 Define a non-SSL HTTP/1.1 Connector on port 8080
            -->
            <Connector connectionTimeout="20000" port="8080" protocol="HTTP/1.1" redirectPort="8443"/>
            <!-- A "Connector" using the shared thread pool-->
            <!--
            <Connector executor="tomcatThreadPool"
                       port="8080" protocol="HTTP/1.1"
                       connectionTimeout="20000"
                       redirectPort="88443" />
            -->
            <!-- Define a SSL HTTP/1.1 Connector on port 88443
                 This connector uses the NIO implementation that requires the JSSE
                 style configuration. When using the APR/native implementation, the
                 OpenSSL style configuration is required as described in the APR/native
                 documentation -->
            <!--
            <Connector port="88443" protocol="org.apache.coyote.http11.Http11NioProtocol"
                       maxThreads="150" SSLEnabled="true" scheme="https" secure="true"
                       clientAuth="false" sslProtocol="TLS" />
            -->
        <Connector SSLEnabled="true" URIEncoding="UTF-8" acceptCount="100"
        clientAuth="false" debug="1" disableUploadTimeout="true"
        enableLookups="false" keystoreFile="../keystore.jks"
        keystorePass="password" maxHttpHeaderSize="8192" keyAlias="selfsigned"
        maxPostSize="0" maxSpareThreads="75" maxThreads="150" minSpareThreads="25"
        port="8443" protocol="org.apache.coyote.http11.Http11Protocol" scheme="https" secure="true"
        sslEnabledProtocols="TLSv1,TLSv1.1,TLSv1.2">
        </Connector>
            <!-- Define an AJP 1.3 Connector on port 8009 -->
            <Connector port="8009" protocol="AJP/1.3" redirectPort="8443"/>


            <!-- An Engine represents the entry point (within Catalina) that processes
                 every request. The Engine implementation for Tomcat stand alone
                 analyzes the HTTP headers included with the request, and passes them
                 on to the appropriate Host (virtual host).
                 Documentation at /docs/config/engine.html -->

            <!-- You should set jvmRoute to support load-balancing via AJP ie :
            <Engine name="Catalina" defaultHost="localhost" jvmRoute="jvm1">
            -->
            <Engine defaultHost="localhost" name="Catalina">

              <!--For clustering, please take a look at documentation at:
                  /docs/cluster-howto.html (simple how to)
                  /docs/config/cluster.html (reference documentation) -->
              <!--
              <Cluster className="org.apache.catalina.ha.tcp.SimpleTcpCluster"/>
              -->

              <!-- Use the LockOutRealm to prevent attempts to guess user passwords
                   via a brute-force attack -->
              <Realm className="org.apache.catalina.realm.LockOutRealm">
                <!-- This Realm uses the UserDatabase configured in the global JNDI
                     resources under the key "UserDatabase". Any edits
                     that are performed against this UserDatabase are immediately
                     available for use by the Realm. -->
                <Realm className="org.apache.catalina.realm.UserDatabaseRealm" resourceName="UserDatabase"/>
              </Realm>

              <Host appBase="webapps" autoDeploy="true" name="localhost" unpackWARs="true">

                <!-- SingleSignOn valve, share authentication between web applications
                     Documentation at: /docs/config/valve.html -->
                <!--
                <Valve className="org.apache.catalina.authenticator.SingleSignOn" />
                -->

                <!-- Access log processes all example.
                     Documentation at: /docs/config/valve.html
                     Note: The pattern used is equivalent to using pattern="common" -->
                <Valve className="org.apache.catalina.valves.AccessLogValve" directory="logs" pattern="%h %l %u %t &quot;%r&quot; %s %b" prefix="localhost_access_log" suffix=".txt"/>

              <Context docBase="files" path="/" />
              </Host>
            </Engine>
          </Service>
        </Server>
        ---------- END SOURCE ----------

        CUSTOMER SUBMITTED WORKAROUND :
        Do not use Java 8.
        Do not disable SSLv3.

        Attachments

          Issue Links

            Activity

              People

                xuelei Xuelei Fan
                webbuggrp Webbug Group
                Votes:
                0 Vote for this issue
                Watchers:
                10 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: