-
Bug
-
Resolution: Fixed
-
P3
-
8u60, 9
-
b48
-
generic
-
generic
| Issue | Fix Version | Assignee | Priority | Status | Resolution | Resolved In Build |
|---|---|---|---|---|---|---|
| JDK-8083217 | emb-9 | Filipp Zhinkin | P3 | Resolved | Fixed | team |
| JDK-8220036 | openjdk8u212 | Filipp Zhinkin | P3 | Resolved | Fixed | b01 |
Following RTM tests assert that PrintPreciseRTMLockingStatistics output should contain non-zero locks count:
compiler/rtm/locking/TestRTMTotalCountIncrRate.java
compiler/rtm/print/TestPrintPreciseRTMLockingStatistics.java
However, both tests use either default RTMTotalCountIncrRate value (64) or value greater than 1 and as a result locks count is incremented only when (rdtsc() & (value - 1) == 0).
There is a chance that such TSC values won't be observed during the test run. In such cases tests listed above will fail.
Fix is pretty simple: relax assertions and verify that amount of lock attempts it non-negative.
compiler/rtm/locking/TestRTMTotalCountIncrRate.java
compiler/rtm/print/TestPrintPreciseRTMLockingStatistics.java
However, both tests use either default RTMTotalCountIncrRate value (64) or value greater than 1 and as a result locks count is incremented only when (rdtsc() & (value - 1) == 0).
There is a chance that such TSC values won't be observed during the test run. In such cases tests listed above will fail.
Fix is pretty simple: relax assertions and verify that amount of lock attempts it non-negative.
- backported by
-
JDK-8083217 RTM tests that assert on non-zero lock statistics are too strict in RTMTotalCountIncrRate > 1 cases
-
- Resolved
-
-
-
- Resolved
-
- relates to
-
-
- Closed
-