-
Enhancement
-
Resolution: Fixed
-
P4
-
9
Issue | Fix Version | Assignee | Priority | Status | Resolution | Resolved In Build |
---|---|---|---|---|---|---|
JDK-8082864 | emb-9 | Kim Barrett | P4 | Resolved | Fixed | team |
The -XX:G1ConfidencePercent option is expected to be an integer percentage. However, there is no code in argument processing to verify that it is a valid percentage.
Instead, dealing with invalid values (e.g. > 100) is presently left to the one user of this option, the constructor for G1CollectorPolicy. There, if an invalid value is detected, the value is clipped to 100 and a warning message is printed (if PrintWarnings option is true).
It would be better to detect the invalid option value during option processing and deal with it there in the normal fashion, rather than leaving it to users of the option to worry about bad values and deal with such in an ad hoc manner. Specifically, the function Arguments::check_vm_args_consistency() should use verify_percentage() to check this option's value.
Instead, dealing with invalid values (e.g. > 100) is presently left to the one user of this option, the constructor for G1CollectorPolicy. There, if an invalid value is detected, the value is clipped to 100 and a warning message is printed (if PrintWarnings option is true).
It would be better to detect the invalid option value during option processing and deal with it there in the normal fashion, rather than leaving it to users of the option to worry about bad values and deal with such in an ad hoc manner. Specifically, the function Arguments::check_vm_args_consistency() should use verify_percentage() to check this option's value.
- backported by
-
JDK-8082864 Improve validation of -XX:G1ConfidencePercent value
- Resolved
- relates to
-
JDK-8071863 Validate G1 options that are expressed as percentages
- Closed
-
JDK-8068739 G1CollectorPolicy uses uninitialized field '_sigma' in the constructor
- Resolved
-
JDK-8008546 WRONG G1CONFIDENCEPERCENT RESULTS IN GUARANTEE(VARIANCE() > -1.0) FAILED
- Closed