Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8073543

Circular include dependency between psScavenge.inline.hpp and psPromotionManager.inline.hpp

    XMLWordPrintable

Details

    • Enhancement
    • Resolution: Fixed
    • P4
    • 9
    • 9
    • hotspot
    • None
    • gc
    • b54

    Backports

      Description

        There's a circular dependency between PSScavenge and PSPromotionManager. One example where this can be seen is the call chain:

         PSPromotionManager::process_popped_location_depth(...)
          PSScavenge::copy_and_push_safe_barrier(...)
           PSPromotionManager::copy_to_survivor_space(...)

        These functions are located in the psScavenge.inline.hpp and psPromotionManager.inline.hpp.

        Today there are these include paths:
         psScavenge.inline.hpp -> psPromotionManager.inline.hpp
         psPromotionManager.inline.hpp -> oop.psgc.inline.hpp -> psScavenge.inline.hpp

        I propose that we move PSScavenge::copy_and_push_safe_barrier to the PSPromotionManager class and get rid of the psPromotionManager.inline.hpp -> oop.psgc.inline.hpp -> psScavenge.inline.hpp
        include chain.

        Attachments

          Issue Links

            Activity

              People

                stefank Stefan Karlsson
                stefank Stefan Karlsson
                Votes:
                1 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: