Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8076532

Fix format warning/error in methodHandles_ppc.cpp

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: P4 P4
    • 9
    • None
    • hotspot
    • None
    • b64
    • ppc

        With newer GCCs we currently get the following error:

        /OpenJDK/jdk9-hs-comp/hotspot/src/cpu/ppc/vm/methodHandles_ppc.cpp: In function ‘void trace_method_handle_stub(const char*, oopDesc*, intptr_t*, intptr_t*)’:
        /OpenJDK/jdk9-hs-comp/hotspot/src/cpu/ppc/vm/methodHandles_ppc.cpp:469:66: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 6 has type ‘intptr_t* {aka long int*}’ [-Werror=format=]
                         adaptername, mh_reg_name, (intptr_t) mh, entry_sp);

        for this code code in methodHandles_ppc.cpp:

          tty->print_cr("MH %s %s="INTPTR_FORMAT " sp=" INTPTR_FORMAT,
                        adaptername, mh_reg_name, (intptr_t) mh, entry_sp);

        The fix is trivial - just use the "p2i()" helper function to cast the pointers to the appropriate type:

          tty->print_cr("MH %s %s="INTPTR_FORMAT " sp=" INTPTR_FORMAT,
                        adaptername, mh_reg_name, p2i(mh), p2i(entry_sp));

              simonis Volker Simonis
              simonis Volker Simonis
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: