Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8078021

SATB apply_closure_to_completed_buffer should have closure argument

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Fixed
    • Icon: P4 P4
    • 9
    • 9
    • hotspot
    • None
    • gc
    • b64
    • generic
    • generic

        SATBMarkQueueSet::apply_closure_to_completed_buffer() presently takes a worker_id index. It uses that to look up the closure associated with the worker by a preceding call to set_closure.

        There is only one caller of this apply function, CMTask::drain_satb_buffers. It creates the desired closure, associates the closure with its worker id, and then calls apply_closure_to_completed_buffer.

        We could eliminate set_closure and the underlying data structure, by simply having the apply_closure_xxx function take the closure as an argument rather than the worker id.

              kbarrett Kim Barrett
              kbarrett Kim Barrett
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: