-
Task
-
Resolution: Fixed
-
P4
-
9
-
b64
-
generic
-
generic
Issue | Fix Version | Assignee | Priority | Status | Resolution | Resolved In Build |
---|---|---|---|---|---|---|
JDK-8085650 | emb-9 | Attila Szegedi | P4 | Resolved | Fixed | team |
JDK-8087078 | 8u65 | Attila Szegedi | P4 | Resolved | Fixed | b01 |
JDK-8080473 | 8u60 | Attila Szegedi | P4 | Resolved | Fixed | b18 |
JDK-8138502 | emb-8u65 | Unassigned | P4 | Resolved | Fixed | b01 |
JDK-8086231 | emb-8u60 | Attila Szegedi | P4 | Resolved | Fixed | team |
Nashorn's Node class has both a "TokenType tokenType()" method and a "boolean isTokenType(TokenType)" method, and often we can see expressions of form "node.tokenType() == <tokenType>" that could be consistently replaced with "node.isTokenType(<tokenType>).
There's also some weird roundabout usage of "Token.descType(node.getToken())" in places which should simply by "node.tokenType()".
No big deal, but API usage consistency is nice to have for clarity.
There's also some weird roundabout usage of "Token.descType(node.getToken())" in places which should simply by "node.tokenType()".
No big deal, but API usage consistency is nice to have for clarity.
- backported by
-
JDK-8080473 Enforce best practices for Node token API usage
-
- Resolved
-
-
JDK-8085650 Enforce best practices for Node token API usage
-
- Resolved
-
-
JDK-8086231 Enforce best practices for Node token API usage
-
- Resolved
-
-
JDK-8087078 Enforce best practices for Node token API usage
-
- Resolved
-
-
JDK-8138502 Enforce best practices for Node token API usage
-
- Resolved
-