Enforce best practices for Node token API usage

XMLWordPrintable

    • Type: Task
    • Resolution: Fixed
    • Priority: P4
    • 9
    • Affects Version/s: 9
    • Component/s: core-libs
    • b64
    • generic
    • generic

        Nashorn's Node class has both a "TokenType tokenType()" method and a "boolean isTokenType(TokenType)" method, and often we can see expressions of form "node.tokenType() == <tokenType>" that could be consistently replaced with "node.isTokenType(<tokenType>).

        There's also some weird roundabout usage of "Token.descType(node.getToken())" in places which should simply by "node.tokenType()".

        No big deal, but API usage consistency is nice to have for clarity.

              Assignee:
              Attila Szegedi
              Reporter:
              Attila Szegedi
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: