Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8079362

Enforce best practices for Node token API usage

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Fixed
    • Icon: P4 P4
    • 9
    • 9
    • core-libs
    • b64
    • generic
    • generic

        Nashorn's Node class has both a "TokenType tokenType()" method and a "boolean isTokenType(TokenType)" method, and often we can see expressions of form "node.tokenType() == <tokenType>" that could be consistently replaced with "node.isTokenType(<tokenType>).

        There's also some weird roundabout usage of "Token.descType(node.getToken())" in places which should simply by "node.tokenType()".

        No big deal, but API usage consistency is nice to have for clarity.

              attila Attila Szegedi
              attila Attila Szegedi
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: