Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8089046

8.0-graphics-scrum-2004: up to 60% performance regressions in Controls.TextArea.v_scroll-wrap

XMLWordPrintable

      There is up to 60% performance regression in Controls.TextArea.v_scroll-255x1000-wrap in promoted build fx8.0-b118. This regression was actually introduced in 8.0-graphics-scrum-2004 which contains:
          1. Fix to RT-34305: Remove old non working anti-aliasing code
             This is a low risk fix. Passed clean, build and sanity testing.
             Post Commit Reviewers: kcr and vadim — Chien Yang / detail
          2. RT-33776 : [2d traversal] Focus indicator moves to unexpected place
             Reviewed by: jgiles

          3. This commit contains refactoring and code cleanup before the actual fix. — Martin Sladecek / detail
             RT-34219: fixed TextArea's scrollbar after deleting its content.
             Reviewed-by: Jonathan. — Pavel Safrata / detail

      JPA profiles show that the time spent in Scene.doLayoutPass() was increased from
      0.173 sec to 26.690 sec (total run time was 30 sec). This is because we now spend
      19.434 sec in com.sun.javafx.scene.control.skin.ScrollPaneSkin.layoutChildren() and
       7.215 sec in com.sun.javafx.scene.control.skin.TextAreaSkin.layoutChildren().

      So, looks like the regression is caused by "RT-34219: fixed TextArea's scrollbar after deleting its content."

      Note, the regression is observed on all platforms including Windows and MacOS.
      On Windows the regression is better noticed in SW pipeline.

      Steps to run Controls.ListView-Keyboard
      > cd JFX_WS/tests/performance/Controls/
      > ant
      > java -Djavafx.animation.fullspeed=true
              -cp "JFX_HOME/rt/lib/ext/jfxrt.jar;./dist/Controls.jar;../FXBenchmark/dist/FXBenchmark.jar;../../../import/benchmarks-2.1.1/benchmarks-2.1.1.jar"
             jrockit.bm.Main controls.bm.TextAreaBenchmark -i 1 -wt 0 -tr 60 -line-len 255 -line-num 1000 -mode V_SCROLL -wrap-text true

            ckyang Chien Yang (Inactive)
            epavlova Ekaterina Pavlova
            Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

              Created:
              Updated:
              Resolved:
              Imported: