-
Enhancement
-
Resolution: Won't Fix
-
P4
-
8u5
The code samples in the tutorial for TableView, TreeView, and TreeTableView seem to be of generally poor quality.
As a specific example, consider listing 15.2 in http://docs.oracle.com/javase/8/javafx/user-interface-tutorial/tree-table-view.htm.
The cell value factories defined here return ReadOnlyStringWrappers, instead of returning the properties defined in the Employee class. These obviously won't get updated if the underlying data changes, and this is causing confusion among users (see, e.g. http://stackoverflow.com/questions/23545051/javafx-treetableview-cell-value-not-getting-updated/).
The code in that listing also fails to follow general good practice, both in the context of JavaFX programming and general Java programming. The set/get methods in Employee should be final (http://www.oracle.com/us/technologies/java/javafx-2-prog-model-1524061.pdf), and the types of the property accessor methods (nameProperty() and emailProperty()) should be StringProperty (at worst), not SimpleStringProperty. The equivalent code for the model classes in TableView and TreeTable sometimes even lacks the property accessors entirely.
As a specific example, consider listing 15.2 in http://docs.oracle.com/javase/8/javafx/user-interface-tutorial/tree-table-view.htm.
The cell value factories defined here return ReadOnlyStringWrappers, instead of returning the properties defined in the Employee class. These obviously won't get updated if the underlying data changes, and this is causing confusion among users (see, e.g. http://stackoverflow.com/questions/23545051/javafx-treetableview-cell-value-not-getting-updated/).
The code in that listing also fails to follow general good practice, both in the context of JavaFX programming and general Java programming. The set/get methods in Employee should be final (http://www.oracle.com/us/technologies/java/javafx-2-prog-model-1524061.pdf), and the types of the property accessor methods (nameProperty() and emailProperty()) should be StringProperty (at worst), not SimpleStringProperty. The equivalent code for the model classes in TableView and TreeTable sometimes even lacks the property accessors entirely.