Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8096428

Broken dependency with openZip

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: P4 P4
    • 8u60
    • 8u40
    • javafx

      OpenZip is meant to provide bundling for OpenJFX.

      gradle openZip
      -or-
      gradle zips

      should both do the same thing in an open build. I want to be able to build the openBundle even in a closed tree, hence the desire for openZips without any other build flag. Current openZip[Win|Mac...] works, but not the parent.

      The clause:

      task openZip() {
          if (!BUILD_CLOSED) {
              zips.dependsOn(openZip)
          }
      }

      shows that openZip is only added to zips for a !BUILD_CLOSED.

      But later, instead of adding the openZip[Win|Mac...] to openZip, I conditionally added it to zips.

      So... the following achieves the original intent

      diff -r 5d371a34ddf1 build.gradle
      --- a/build.gradle Thu Feb 26 13:31:18 2015 +1300
      +++ b/build.gradle Mon Mar 09 17:53:00 2015 -0400
      @@ -3389,8 +3389,8 @@
       
           if (!BUILD_CLOSED) {
               publicExports.dependsOn(exportTask)
      - zips.dependsOn(zipTask)
           }
      + openZip.dependsOn(zipTask)
       }
       

            ddhill David Hill (Inactive)
            ddhill David Hill (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:
              Imported: