P4
JS-to-Java bridge should be well documented. Part of the javadoc will be pushed as part of RT-19917, then it will have to be updated to:
Discuss primitive type mapping, then JSObject.
Note that Node objects also extend JSObject.
Discussion of JSObject.
Use of setMember to bind Java object to JavaScript properties.
Mapping Java values to JavaScript
Note this applies to setMember; the parameters of JSObject#call; and the result of in Javascript calling methods (or accesng) fields of Java object (next section?).
Discuss primitive type mapping, then JSObject.
Note that Node objects also extend JSObject.
Discussion of JSObject.
Use of setMember to bind Java object to JavaScript properties.
Mapping Java values to JavaScript
Note this applies to setMember; the parameters of JSObject#call; and the result of in Javascript calling methods (or accesng) fields of Java object (next section?).
- relates to
-
JDK-8127416 Remove WebEngine.add/removeJavaScriptBinding()
-
- Closed
-
[JDK-8102185] Document JS-to-Java bridge
SQE: no test development planned for this
I checked in the patch, with a minor changes based on the comments.
248 * If there are multiple Java methods with the given name,
249 * then the engine selects one matching the the number of parameters
"the the" should probably be just "the"
249 * then the engine selects one matching the the number of parameters
"the the" should probably be just "the"
netscape.javascript.JSObject does not have a public constant for [undefined]. I think this is a bug in LiveConnect.
I added an UNDEFINED field to com.sun.webpane.webkit.JSObject, but alas that's an "internal" class.
I'd like like to add this field to netscape.javascript.JSObject - and ideally move this class to JDK, but don't know how to do that.
I don't think it hurts to have redundant information of JSObject, but since it is redundant perhaps it should be more terse, with an explicit or implicit suggestion to check the JSObject doc for details. I'll do some more word-smithing on this.
I think the description of setMember in the following section should not be a description per se, but on its use (as an idiom) for passing Java object to JavaScript. I'll als do some word-smithing here.
I added an UNDEFINED field to com.sun.webpane.webkit.JSObject, but alas that's an "internal" class.
I'd like like to add this field to netscape.javascript.JSObject - and ideally move this class to JDK, but don't know how to do that.
I don't think it hurts to have redundant information of JSObject, but since it is redundant perhaps it should be more terse, with an explicit or implicit suggestion to check the JSObject doc for details. I'll do some more word-smithing on this.
I think the description of setMember in the following section should not be a description per se, but on its use (as an idiom) for passing Java object to JavaScript. I'll als do some word-smithing here.
180 * The undefined value maps to a specific unique String
181 * object whose value is {@code "undefined"}.
Doesn't LiveConnect have a public constant for [undefined]?
191 * The {@link netscape.javascript.JSObject#getMember JSObject.getMember}
192 * method reads a named property of the underlying JavaScript object,
193 * while the {@link netscape.javascript.JSObject#call JSObject.call} method
194 * calls a named method (i.e. a function-valued property).
195 * You can also define new members using the
196 * {@link netscape.javascript.JSObject#setMember JSObject.setMember} method.
The description of JSObject methods is better moved to JSObject.java, and here we could just have a reference. setMember() is described in the next section anyway.
181 * object whose value is {@code "undefined"}.
Doesn't LiveConnect have a public constant for [undefined]?
191 * The {@link netscape.javascript.JSObject#getMember JSObject.getMember}
192 * method reads a named property of the underlying JavaScript object,
193 * while the {@link netscape.javascript.JSObject#call JSObject.call} method
194 * calls a named method (i.e. a function-valued property).
195 * You can also define new members using the
196 * {@link netscape.javascript.JSObject#setMember JSObject.setMember} method.
The description of JSObject methods is better moved to JSObject.java, and here we could just have a reference. setMember() is described in the next section anyway.
This covers more information:
http://javaweb.us.oracle.com/jcg/fx-webrevs/RT-19983/1
http://javaweb.us.oracle.com/jcg/fx-webrevs/RT-19983/1