-
Enhancement
-
Resolution: Fixed
-
P5
-
7u6
the instance field name in T2KFontFile, to the best of my knowledge, is not used. I believe it (and all related code) could be removed.
If we decided to keep this field, we should fix the constructor:
private T2KFontFile(String name, String filename, int fIndex)
throws Exception {
this.name = name;
this.filename = filename;
init(fIndex);
if (name == null || name.equals("")) {
name = fullName;
if (name == null) {
name = "";
}
}
}
note that the final 5 lines in this code is adjusting the parameter name, not the instance field (this.name).
If we decided to keep this field, we should fix the constructor:
private T2KFontFile(String name, String filename, int fIndex)
throws Exception {
this.name = name;
this.filename = filename;
init(fIndex);
if (name == null || name.equals("")) {
name = fullName;
if (name == null) {
name = "";
}
}
}
note that the final 5 lines in this code is adjusting the parameter name, not the instance field (this.name).