Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8102865

Unnecessary call to getParent

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Fixed
    • Icon: P4 P4
    • 8
    • 8
    • javafx

      There's an unneeded call to getParent because the value is already stored in the variable

      diff --git a/modules/graphics/src/main/java/javafx/scene/Node.java b/modules/graphics/src/main/java/javafx/scene/Node.java
      --- a/modules/graphics/src/main/java/javafx/scene/Node.java
      +++ b/modules/graphics/src/main/java/javafx/scene/Node.java
      @@ -7605,7 +7605,7 @@
               boolean isTreeVisible = isVisible();
               if (isTreeVisible) {
                   final Parent p = getParent();
      - isTreeVisible = p != null ? getParent().impl_isTreeVisible() :
      + isTreeVisible = p != null ? p.impl_isTreeVisible() :
                           clipParent != null ? clipParent.impl_isTreeVisible() :
                           getSubScene() == null || getSubScene().impl_isTreeVisible();
               }

            psafrata Pavel Ĺ afrata
            tschindl Tom Schindl
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved:
              Imported: