-
Bug
-
Resolution: Fixed
-
P4
-
8
-
None
The action: look at upcalls and mark as called by native any we use that are not notify methods.
------
Thanks for adding the comments to these methods, David.
By default, we know that any notify*() methods may be called from native/implementation code. There's a few direct usages of other methods and variables, and IIRC they're all properly documented in a comment just above the method or variable in question, so that developers don't forget about that.
Would it be feasible to always document any Glass methods/variables used directly form native (on any platform)? Could the embedded team reexamine their code and add any missing comments please?
--
best regards,
Anthony
+ // used by Lens Native
+ static private synchronized void add(Window window) {
+ Window.visibleWindows.add(window);
+ }
------
Thanks for adding the comments to these methods, David.
By default, we know that any notify*() methods may be called from native/implementation code. There's a few direct usages of other methods and variables, and IIRC they're all properly documented in a comment just above the method or variable in question, so that developers don't forget about that.
Would it be feasible to always document any Glass methods/variables used directly form native (on any platform)? Could the embedded team reexamine their code and add any missing comments please?
--
best regards,
Anthony
+ // used by Lens Native
+ static private synchronized void add(Window window) {
+ Window.visibleWindows.add(window);
+ }