Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8124288

Need to revert unintended change in RT-28215 to LabeledText.java

    XMLWordPrintable

Details

    Description

      The following changeset contains a change that is completely unrelated to removing cagsrc.float:

      changeset: 2719:26b56085a3ff
      user: Felipe Heidrich
      date: Tue Feb 26 13:54:06 2013 -0800
      summary: RT-28215: consider removing cagsrc.float from javafx.geom

      I expect you didn't mean to include a change to the following file (since it wasn't in your webrev) : javafx-ui-controls/src/com/sun/javafx/scene/control/skin/LabeledText.java

      Please revert this unintended change as it is causing the following unit test failures:

         [junit] Testsuite: com.sun.javafx.scene.control.skin.LabelSkinLayoutTest
         [junit] Tests run: 189, Failures: 15, Errors: 0, Time elapsed: 1 sec
         [junit] [junit] Testcase: graphic_Text_CENTER[0](com.sun.javafx.scene.control.skin.LabelSkinLayoutTest): FAILED
         [junit] expected:<67.0> but was:<134.0>
         [junit] junit.framework.AssertionFailedError: expected:<67.0> but was:<134.0>
         [junit] at com.sun.javafx.scene.control.skin.LabelSkinLayoutTest.assertCenteredVertically(LabelSkinLayoutTest.java:163)
         [junit] at com.sun.javafx.scene.control.skin.LabelSkinLayoutTest.graphic_Text_CENTER(LabelSkinLayoutTest.java:726)
         [junit] [junit] [junit] Testcase: graphic_Text_TOP[0](com.sun.javafx.scene.control.skin.LabelSkinLayoutTest): FAILED
         [junit] expected:<-22.0> but was:<140.0>
         [junit] junit.framework.AssertionFailedError: expected:<-22.0> but was:<140.0>
         [junit] at com.sun.javafx.scene.control.skin.LabelSkinLayoutTest.graphic_Text_TOP(LabelSkinLayoutTest.java:232)
         [junit] [junit] [junit] Testcase: graphic_Text_RIGHT[0](com.sun.javafx.scene.control.skin.LabelSkinLayoutTest): FAILED
         [junit] expected:<67.0> but was:<134.0>
         [junit] junit.framework.AssertionFailedError: expected:<67.0> but was:<134.0>
         [junit] at com.sun.javafx.scene.control.skin.LabelSkinLayoutTest.assertCenteredVertically(LabelSkinLayoutTest.java:163)
         [junit] at com.sun.javafx.scene.control.skin.LabelSkinLayoutTest.graphic_Text_RIGHT(LabelSkinLayoutTest.java:357)
         [junit] [junit] [junit] Testcase: graphic_Text_BOTTOM[0](com.sun.javafx.scene.control.skin.LabelSkinLayoutTest): FAILED
         [junit] expected:<-11.0> but was:<129.0>
         [junit] junit.framework.AssertionFailedError: expected:<-11.0> but was:<129.0>
         [junit] at com.sun.javafx.scene.control.skin.LabelSkinLayoutTest.graphic_Text_BOTTOM(LabelSkinLayoutTest.java:479)
         [junit] [junit] [junit] Testcase: graphic_Text_LEFT[0](com.sun.javafx.scene.control.skin.LabelSkinLayoutTest): FAILED
         [junit] expected:<13.0> but was:<0.0>
         [junit] junit.framework.AssertionFailedError: expected:<13.0> but was:<0.0>
         [junit] at com.sun.javafx.scene.control.skin.LabelSkinLayoutTest.graphic_Text_LEFT(LabelSkinLayoutTest.java:602)
         [junit] [junit] [junit] Testcase: graphic_Text_CENTER[1](com.sun.javafx.scene.control.skin.LabelSkinLayoutTest): FAILED
         [junit] expected:<67.0> but was:<134.0>
         [junit] junit.framework.AssertionFailedError: expected:<67.0> but was:<134.0>
         [junit] at com.sun.javafx.scene.control.skin.LabelSkinLayoutTest.assertCenteredVertically(LabelSkinLayoutTest.java:163)
         [junit] at com.sun.javafx.scene.control.skin.LabelSkinLayoutTest.graphic_Text_CENTER(LabelSkinLayoutTest.java:726)
         [junit] [junit] [junit] Testcase: graphic_Text_TOP[1](com.sun.javafx.scene.control.skin.LabelSkinLayoutTest): FAILED
         [junit] expected:<-32.0> but was:<135.0>
         [junit] junit.framework.AssertionFailedError: expected:<-32.0> but was:<135.0>
         [junit] at com.sun.javafx.scene.control.skin.LabelSkinLayoutTest.graphic_Text_TOP(LabelSkinLayoutTest.java:232)
         [junit] [junit] [junit] Testcase: graphic_Text_RIGHT[1](com.sun.javafx.scene.control.skin.LabelSkinLayoutTest): FAILED
         [junit] expected:<67.0> but was:<134.0>
         [junit] junit.framework.AssertionFailedError: expected:<67.0> but was:<134.0>
         [junit] at com.sun.javafx.scene.control.skin.LabelSkinLayoutTest.assertCenteredVertically(LabelSkinLayoutTest.java:163)
         [junit] at com.sun.javafx.scene.control.skin.LabelSkinLayoutTest.graphic_Text_RIGHT(LabelSkinLayoutTest.java:357)
         [junit] [junit] [junit] Testcase: graphic_Text_BOTTOM[1](com.sun.javafx.scene.control.skin.LabelSkinLayoutTest): FAILED
         [junit] expected:<-1.0> but was:<134.0>
         [junit] junit.framework.AssertionFailedError: expected:<-1.0> but was:<134.0>
         [junit] at com.sun.javafx.scene.control.skin.LabelSkinLayoutTest.graphic_Text_BOTTOM(LabelSkinLayoutTest.java:479)
         [junit] [junit] [junit] Testcase: graphic_Text_LEFT[1](com.sun.javafx.scene.control.skin.LabelSkinLayoutTest): FAILED
         [junit] expected:<23.0> but was:<0.0>
         [junit] junit.framework.AssertionFailedError: expected:<23.0> but was:<0.0>
         [junit] at com.sun.javafx.scene.control.skin.LabelSkinLayoutTest.graphic_Text_LEFT(LabelSkinLayoutTest.java:602)
         [junit] [junit] [junit] Testcase: graphic_Text_CENTER[2](com.sun.javafx.scene.control.skin.LabelSkinLayoutTest): FAILED
         [junit] expected:<67.0> but was:<134.0>
         [junit] junit.framework.AssertionFailedError: expected:<67.0> but was:<134.0>
         [junit] at com.sun.javafx.scene.control.skin.LabelSkinLayoutTest.assertCenteredVertically(LabelSkinLayoutTest.java:163)
         [junit] at com.sun.javafx.scene.control.skin.LabelSkinLayoutTest.graphic_Text_CENTER(LabelSkinLayoutTest.java:726)
         [junit] [junit] [junit] Testcase: graphic_Text_TOP[2](com.sun.javafx.scene.control.skin.LabelSkinLayoutTest): FAILED
         [junit] expected:<-42.0> but was:<130.0>
         [junit] junit.framework.AssertionFailedError: expected:<-42.0> but was:<130.0>
         [junit] at com.sun.javafx.scene.control.skin.LabelSkinLayoutTest.graphic_Text_TOP(LabelSkinLayoutTest.java:232)
         [junit] [junit] [junit] Testcase: graphic_Text_RIGHT[2](com.sun.javafx.scene.control.skin.LabelSkinLayoutTest): FAILED
         [junit] expected:<67.0> but was:<134.0>
         [junit] junit.framework.AssertionFailedError: expected:<67.0> but was:<134.0>
         [junit] at com.sun.javafx.scene.control.skin.LabelSkinLayoutTest.assertCenteredVertically(LabelSkinLayoutTest.java:163)
         [junit] at com.sun.javafx.scene.control.skin.LabelSkinLayoutTest.graphic_Text_RIGHT(LabelSkinLayoutTest.java:357)
         [junit] [junit] [junit] Testcase: graphic_Text_BOTTOM[2](com.sun.javafx.scene.control.skin.LabelSkinLayoutTest): FAILED
         [junit] expected:<9.0> but was:<139.0>
         [junit] junit.framework.AssertionFailedError: expected:<9.0> but was:<139.0>
         [junit] at com.sun.javafx.scene.control.skin.LabelSkinLayoutTest.graphic_Text_BOTTOM(LabelSkinLayoutTest.java:479)
         [junit] [junit] [junit] Testcase: graphic_Text_LEFT[2](com.sun.javafx.scene.control.skin.LabelSkinLayoutTest): FAILED
         [junit] expected:<33.0> but was:<0.0>
         [junit] junit.framework.AssertionFailedError: expected:<33.0> but was:<0.0>
         [junit] at com.sun.javafx.scene.control.skin.LabelSkinLayoutTest.graphic_Text_LEFT(LabelSkinLayoutTest.java:602)
         [junit] [junit] [junit] Test com.sun.javafx.scene.control.skin.LabelSkinLayoutTest FAILED
         [junit] Testsuite: com.sun.javafx.scene.control.skin.LabelSkinTest
         [junit] Tests run: 199, Failures: 2, Errors: 0, Time elapsed: 0.984 sec
         [junit] [junit] Testcase: wrapTextChangesOnLabelShouldInvalidateLayoutAndDisplayTextAndWrappingWidth(com.sun.javafx.scene.control.skin.LabelSkinTest): FAILED
         [junit] [junit] junit.framework.AssertionFailedError: [junit] at com.sun.javafx.scene.control.skin.LabelSkinTest.wrapTextChangesOnLabelShouldInvalidateLayoutAndDisplayTextAndWrappingWidth(LabelSkinTest.java:300)
         [junit] [junit] [junit] Testcase: widthChangesWhenWrapTextIsTrueUpdatesTheWrappingWidth(com.sun.javafx.scene.control.skin.LabelSkinTest): FAILED
         [junit] [junit] junit.framework.AssertionFailedError: [junit] at com.sun.javafx.scene.control.skin.LabelSkinTest.widthChangesWhenWrapTextIsTrueUpdatesTheWrappingWidth(LabelSkinTest.java:192)
         [junit] [junit] [junit] Test com.sun.javafx.scene.control.skin.LabelSkinTest FAILED

      Attachments

        Activity

          People

            fheidric Felipe Heidrich (Inactive)
            kcr Kevin Rushforth
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              Imported: