-
Bug
-
Resolution: Fixed
-
P3
-
8
Controls.ListView-Keyboard and Controls.TableView-Keyboard benchmarks are broken in build
3.0-controls-scrum-60 and as result produce invalid performance results.
One MacOS they show up to 30% regression:
ListView-Keyboard: -25% (-10.74)
TableView-Keyboard: -30% (-20.27)
If you launch benchmarks you can see that nothing is happened during first round (when we scroll down).
On MacOS it results in lower FPS during that time (run with "-debug true" to see) =>
the results show regression.
The regression seems to be caused byRT-23873 "Investigate (and improve) ListView / TreeView / TableView performance (trying to reduce the frequency with which we call cell.impl_processCSS(false))" as this is the only change integrated in build 3.0-controls-scrum-60.
Steps to run benchmarks:
> cd JFX_WS/tests/performance/
> ant
> TableView-Keyboard
java -cp "JFX_HOME/rt/lib/jfxrt.jar;./dist/Controls.jar;../FXBenchmark/dist/FXBenchmark.jar;../../../import/benchmarks-2.1.1/benchmarks-2.1.1.jar"
jrockit.bm.Main controls.bm.TableViewBenchmark -i 3 -wt 5 -tr 15 -mode keyboard -usePulse true -keysPerInjection 1 -cells 150 30
> ListView-Keyboard
java -cp "JFX_HOME/rt/lib/jfxrt.jar;./dist/Controls.jar;../FXBenchmark/dist/FXBenchmark.jar;../../../import/benchmarks-2.1.1/benchmarks-2.1.1.jar"
jrockit.bm.Main controls.bm.ListViewBenchmark -i 3 -wt 5 -tr 15 -cells 10000 -mode keyboard -keysPerInjection 100
3.0-controls-scrum-60 and as result produce invalid performance results.
One MacOS they show up to 30% regression:
ListView-Keyboard: -25% (-10.74)
TableView-Keyboard: -30% (-20.27)
If you launch benchmarks you can see that nothing is happened during first round (when we scroll down).
On MacOS it results in lower FPS during that time (run with "-debug true" to see) =>
the results show regression.
The regression seems to be caused by
Steps to run benchmarks:
> cd JFX_WS/tests/performance/
> ant
> TableView-Keyboard
java -cp "JFX_HOME/rt/lib/jfxrt.jar;./dist/Controls.jar;../FXBenchmark/dist/FXBenchmark.jar;../../../import/benchmarks-2.1.1/benchmarks-2.1.1.jar"
jrockit.bm.Main controls.bm.TableViewBenchmark -i 3 -wt 5 -tr 15 -mode keyboard -usePulse true -keysPerInjection 1 -cells 150 30
> ListView-Keyboard
java -cp "JFX_HOME/rt/lib/jfxrt.jar;./dist/Controls.jar;../FXBenchmark/dist/FXBenchmark.jar;../../../import/benchmarks-2.1.1/benchmarks-2.1.1.jar"
jrockit.bm.Main controls.bm.ListViewBenchmark -i 3 -wt 5 -tr 15 -cells 10000 -mode keyboard -keysPerInjection 100