Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8132344

stub sizes too small

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: P3 P3
    • 9
    • 9
    • hotspot
    • None

      As part of JDK-8003853, emit_to_interp_stub sizing was changed from

          start_a_stub(Compile::MAX_stubs_size);

      to

          start_a_stub(to_interp_stub_size()*2);

      In retrospect, it seems better to use

          start_a_stub(to_interp_stub_size());

      and check at the end that the size was big enough, like PPC does:

           assert((__ offset() - offset) <= (int)to_interp_stub_size(), "stub too big");

      or make sure a similar check is part of end_a_stub().

      We also need to make sure Compile::MAX_stubs_size is big enough. If we wanted to make sure it was always big enough, we could change it from an enum to a variable, and do:

      Compile::MAX_stubs_size = MAX(Compile::MAX_stubs_size, to_interp_stub_size());

            Unassigned Unassigned
            dlong Dean Long
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved: