Backports
| Issue | Fix Version | Assignee | Priority | Status | Resolution | Resolved In Build |
|---|---|---|---|---|---|---|
| JDK-8135675 | emb-9 | Christian Tornqvist | P4 | Resolved | Fixed | team |
Description
"8081202 C++11 requires a space between literal and identifier", see
http://mail.openjdk.java.net/pipermail/hotspot-dev/2015-May/018665.html
fixed a number of places in hotspot coding with missing spaces between literals and identifiers.
When experimenting with Visual Studio 2015 (which refuses compiling such code) , I noticed that this fix is missing here (introduced by "8087333: Optionally Pre-Generate the HotSpot Template Interpreter"):
hotspot/src/share/vm/interpreter/interpreterRuntime.cpp
The following small diff (contributed by "matthias.baesken@sap.com") is fixing the remaining issue.
1306c1306
< tty->print_cr("argument handler #%d at "PTR_FORMAT" for fingerprint " UINT64_FORMAT,
---
> tty->print_cr("argument handler #%d at " PTR_FORMAT " for fingerprint " UINT64_FORMAT,
1316c1316
< tty->print_cr("duplicate argument handler #%d for fingerprint " UINT64_FORMAT "(old: "PTR_FORMAT", new : "PTR_FORMAT")",
---
> tty->print_cr("duplicate argument handler #%d for fingerprint " UINT64_FORMAT "(old: " PTR_FORMAT ", new : " PTR_FORMAT ")",
http://mail.openjdk.java.net/pipermail/hotspot-dev/2015-May/018665.html
fixed a number of places in hotspot coding with missing spaces between literals and identifiers.
When experimenting with Visual Studio 2015 (which refuses compiling such code) , I noticed that this fix is missing here (introduced by "8087333: Optionally Pre-Generate the HotSpot Template Interpreter"):
hotspot/src/share/vm/interpreter/interpreterRuntime.cpp
The following small diff (contributed by "matthias.baesken@sap.com") is fixing the remaining issue.
1306c1306
< tty->print_cr("argument handler #%d at "PTR_FORMAT" for fingerprint " UINT64_FORMAT,
---
> tty->print_cr("argument handler #%d at " PTR_FORMAT " for fingerprint " UINT64_FORMAT,
1316c1316
< tty->print_cr("duplicate argument handler #%d for fingerprint " UINT64_FORMAT "(old: "PTR_FORMAT", new : "PTR_FORMAT")",
---
> tty->print_cr("duplicate argument handler #%d for fingerprint " UINT64_FORMAT "(old: " PTR_FORMAT ", new : " PTR_FORMAT ")",
Attachments
Issue Links
- backported by
-
JDK-8135675 C++11 requires a space between literal and identifier
-
- Resolved
-
- relates to
-
JDK-8081202 Hotspot compile warning: "Invalid suffix on literal; C++11 requires a space between literal and identifier"
-
- Resolved
-