Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8133914

JShell API: SnippetEvent naming

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: P4 P4
    • 9-repo-kulla
    • 9-repo-kulla
    • tools
    • None

      Yeah, I like onSnippetEvent.

      On 8/18/2015 6:37 PM, Robert Field wrote:
      > OK. But then onSnippetChange() is arguably more problematic. You had
      > suggested onSnippetEvent() but the users of this form I've seen were of
      > the form onXxxChange().
      >
      >
      >
      >
      > On August 18, 2015 2:33:35 PM Brian Goetz <brian.goetz@oracle.com> wrote:
      >
      >> Hmm, I would think a SnippetEvent is a just an event in which a snippet
      >> played the starring role. Which could be "snippet was created",
      >> "someone pulled a clever practical joke on this snippet", "this little
      >> snippet went to market", etc?
      >>
      >> On 8/18/2015 5:31 PM, Robert Field wrote:
      >>> If be alright with that, my only concern is that Snippet is immutable,
      >>> makes it seem like Snippet is changing.
      >>>
      >>>
      >>>
      >>>
      >>> On August 18, 2015 2:00:25 PM Brian Goetz <brian.goetz@oracle.com>
      >>> wrote:
      >>>
      >>>> onSnippetEvent seems to cover all eventualities (as well as being less
      >>>> bulky)?

            rfield Robert Field (Inactive)
            rfield Robert Field (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: