Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8134856

Incorrect use of PLAB::min_size() in MaxPLABSizeBounds

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: P4 P4
    • 9
    • 9
    • hotspot
    • gc
    • b83

        The method MaxPLABSizeBounds() in runtime/commandLineFlagConstraintsGC.cpp uses PLAB::min_size() in the error string instead of PLAB::max_size().

        E.g.

         118 static Flag::Error MaxPLABSizeBounds(const char* name, size_t value, bool verbose) {
         119 #if INCLUDE_ALL_GCS
         120 if ((UseConcMarkSweepGC || UseG1GC) && (value > PLAB::max_size())) {
         121 CommandLineError::print(verbose,
         122 "%s (" SIZE_FORMAT ") must be "
         123 "less than or equal to ergonomic PLAB maximum size (" SIZE_FORMAT ")\n",
         124 name, value, PLAB::min_size());
         125 return Flag::VIOLATES_CONSTRAINT;
         126 }
         127 #endif // INCLUDE_ALL_GCS
         128 return Flag::SUCCESS;
         129 }

        See line 124

              tschatzl Thomas Schatzl
              tschatzl Thomas Schatzl
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Created:
                Updated:
                Resolved: