-
Type:
Bug
-
Resolution: Fixed
-
Priority:
P3
-
Affects Version/s: 9-repo-kulla
-
Component/s: tools
-
None
Per Maurizio review --
* TreeDependencyScanner
- not sure why Object is being used as a return type for the visitor methods; you could probably just use Void and then use scan() instead of scanAndReduce() [given there's nothing to reduce] ?
- I'm not sure you need the scanDeclaration method - it is only used in Scan.processVariable - which runs it on a variable's type - but variable types are already scanned by TDS references with the right 'decl' set?
* TreeDependencyScanner
- not sure why Object is being used as a return type for the visitor methods; you could probably just use Void and then use scan() instead of scanAndReduce() [given there's nothing to reduce] ?
- I'm not sure you need the scanDeclaration method - it is only used in Scan.processVariable - which runs it on a variable's type - but variable types are already scanned by TDS references with the right 'decl' set?