Issue | Fix Version | Assignee | Priority | Status | Resolution | Resolved In Build |
---|---|---|---|---|---|---|
JDK-8142595 | emb-9 | Andy Herrick | P4 | Resolved | Fixed | team |
all tests in this suite fail, mainly due to "Fake" jre mechanism being broken.
Recent changes in JREInfo and JREMatcher have LaunchSelection.selectJRE() using JREInfo.getValidSorted() instead of JREInfo.getAll(), and this does not include the "fake" jres added by the tests.
Another problem is the code now generates a "MatcherReturnCode" object purely for the tests (not used or returned anywhere else) and test then tests that value. This is a terrible practice. We should remove that class and all references to it. It suffices for the tests to just test if matching functions find a match, (That is what the code cares about)
Recent changes in JREInfo and JREMatcher have LaunchSelection.selectJRE() using JREInfo.getValidSorted() instead of JREInfo.getAll(), and this does not include the "fake" jres added by the tests.
Another problem is the code now generates a "MatcherReturnCode" object purely for the tests (not used or returned anywhere else) and test then tests that value. This is a terrible practice. We should remove that class and all references to it. It suffices for the tests to just test if matching functions find a match, (That is what the code cares about)
- backported by
-
JDK-8142595 Fix JREMatcherTest (junit test)
-
- Resolved
-