SAPs quality process requires a coverity scan. This change contains improvements resulting from this.


Details:

libproc_impl.c:
Do strncpy in case getenv returned a bad string.
Strcat could overflow the buffer. Use strncat instead.

ps_core.c:
Pread not necesarrily terminates interp_name which is printed thereafter.
Increase buffer size by 1 and add '\0'.

stubRoutines_x86.cpp:
Cast to proper type. This way, left and right of '&' have the same type.

attachListener_linux.cpp:
Read does not terminate buf. Size for '\0' is already considered.

os_linux.cpp:
Array sigflags[] has size MAXSIGNUM==32. _NSIG is bigger than
MAXSIGNUM (_NSIG == 65 on my machine).
sig is checked to be smaller than _NSIG. Later, in set_our_sigflags(),
sig is used to access sigflags[MAXSIGNUM] which can overflow the array.
Should we also increase MAXSIGNUM?
os::get_core_path(): read does not terminate string, but strlen is
called on it. The size already forsees one char for the '\0' byte.

codeBuffer.cpp:
New_capacity is not initialized. Figure_expanded_capacities() handles this
correctly, but initializing this is cheep and safe.

dict.cpp:
If j-- is executed for j==0, the loop aborts because j is unsigned (0-- >= b->_cnt).
Instead, only do j++ if necessary.

generateOopMap.cpp:
Idx is read from String. This is only called with constant strings, so compare
should be folded away by optimizing compilers if inlined.

deoptimization.cpp:
If buflen == 0, buf[-1] is accessed.

task.cpp:
Fatal can return if -XX:SuppressErrorAt is used. Just don't access the
array in this case.

attachListener.hpp:
Do strncpy to not overflow buffer. Don't write more chars than before.

heapDumper.cpp:
strncpy does not null terminate.

memoryService.cpp:
Initialization missing.

xmlstream.cpp:
Copy into fixed size buffer could overflow. Use strncat instead.