-
Type:
Bug
-
Resolution: Fixed
-
Priority:
P3
-
Affects Version/s: None
-
Component/s: javafx
-
None
Based on Kevin's comments in JDK-8090865:
A few comments on the tests (not blocking) :
1) As we discussed off line, additional tests could be written as a follow-up to more fully test flow control. Can you file a new JIRA for this?
2) A small modification to the existing tests would go a long way toward that (and might even make more complicated follow-on tests unnecessary given how well-tested the underlying mechanism is with showAndWait).
My thought is to add loopOneStarted and loopOneFinished flags (also for loop two), that you set just before and just after the call to enterNestedEventLoop, respectively. The code that verifies that the loop is running would assert that loopOneStarted is true and loopOneFinished is false. (The code that verifies the return value could additionally check that loopOneFinished is true, but that is already covered by checking the return value.)
A few comments on the tests (not blocking) :
1) As we discussed off line, additional tests could be written as a follow-up to more fully test flow control. Can you file a new JIRA for this?
2) A small modification to the existing tests would go a long way toward that (and might even make more complicated follow-on tests unnecessary given how well-tested the underlying mechanism is with showAndWait).
My thought is to add loopOneStarted and loopOneFinished flags (also for loop two), that you set just before and just after the call to enterNestedEventLoop, respectively. The code that verifies that the loop is running would assert that loopOneStarted is true and loopOneFinished is false. (The code that verifies the return value could additionally check that loopOneFinished is true, but that is already covered by checking the return value.)