Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8144226

Sjavac's handling of include/exclude patterns is buggy, redundant and inconsistent

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • P3
    • 9
    • 9
    • tools
    • b102
    • Verified

    Description

      The -i, -if, -x and -xf are...

      1. Buggy: Sjavac accepts for instance "-xf foo/bar/*" and "-i */foo" even though the semantics is unclear. Seems to behave as a no-op.
      2. Redundant: -i and -if overlap in functionality
      3. Inconsistent: "*" behaves differently depending on location. -if treats it as a file glob pattern, and -i treats it as a directory glob pattern.

      Suggested fix: Drop -if and -xf. Switch to proper glob pattern syntax, and use FileSystem.getPathMatcher.

      Attachments

        Issue Links

          Activity

            People

              alundblad Andreas Lundblad (Inactive)
              alundblad Andreas Lundblad (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: