Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8149116

Make test/Makefile more silent

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Fixed
    • Icon: P4 P4
    • 9
    • 9
    • infrastructure
    • None
    • b106

      The targets in test/Makefile are quite verbose today. For example, `make test-hotspot-internal` currently prints:
      [ehelin@ehelin dev]$ make test-hotspot-internal
      Building target 'test-hotspot-internal' in configuration 'x64-slow'
      make[3]: warning: -jN forced in submake: disabling jobserver mode.
      /home/ehelin/code/jdk9/dev/../deps/install/jpg/infra/builddeps/gnumake-linux_x64/4.0+1.0/gnumake-linux_x64-4.0+1.0.tar.gz/bin/make -k -C /home/ehelin/code/jdk9/dev/hotspot/test CONCURRENCY=1 TEST=hotspot_internal hotspot_internal
      make[4]: Entering directory '/home/ehelin/code/jdk9/dev/hotspot/test'

      I suggest that we remove "Entering directory" and also silcence the make invocation:

      diff -r 3ca929279adb test/Makefile
      --- a/test/Makefile Fri Feb 05 09:41:16 2016 +0100
      +++ b/test/Makefile Fri Feb 05 13:22:06 2016 +0100
      @@ -40,8 +40,7 @@
       define SUBDIR_TEST # subdirectory target
       if [ -d $1 ] ; then \
         if [ -r $1/test/Makefile ] ; then \
      - echo "$(MAKE) -k -C $1/test $2" ; \
      - $(MAKE) -k -C $1/test $2 ; \
      + $(MAKE) --no-print-directory -k -C $1/test $2 ; \
         else \
           echo "ERROR: File does not exist: $1/test/Makefile"; \
           exit 1; \

            ehelin Erik Helin
            ehelin Erik Helin
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: