Details
-
Sub-task
-
Resolution: Fixed
-
P4
-
None
-
None
Description
>> Constructs a loop that runs a given number of iterations.
It looks a little bit unclear, because there is no 'number' arguments in method definition. I suppose it would be better to mention that number of iteration is specified by given method handle invocation result (first arg). Actually, it is mentioned in 'parameters' section, but it is a little bit unclear in description. This part of description is really clear in the countedLoop(MH, MH, MH, MH)
>> The loop counter is an int initialized from the iterations handle evaluation result.
This sentence differs from pseudocode, because loop counter in pseudcode is initialized to 0. It could lead to misunderstanding. Moreover if we are talking about initialization value it would be good to note that the counter is incremented (or decremented) per 1 after each loop step. This part of description is really clear in the countedLoop(MH, MH, MH, MH)
>> The iterations handle must accept the same parameter types as init but return an int
I suppose it would be good to mention that 'iterations' shouldn't be null, because we can't talk about 'null' return value. According to realization, iterations = null leads to message "java.lang.IllegalArgumentException: found non-effectively identical parameter type lists" which is not so easy to decode in terms of countedLoop.
>> The counter is passed to the body function, so that must accept an initial int argument.
The second part looks unclear. Is there typo?
>> The result of the loop execution is the final value of the additional local state.
'Additional state' is defined in 'init' definition (at the end of documentation). At this point it is hard to understand what does it mean. And maybe it would be better to change 'result of loop execution' to 'result of created method handle invocation' or something like this. There is small ambiguity (loop method vs loop result structure). This part of description is really clear in the countedLoop(MH, MH, MH, MH)
>> The body handle must accept the same parameter types as well, preceded by an int parameter for the counter, and a parameter of the same type as init's result.
It would be good to add information about body return type. According to MethodHandles.loop(...), pseudocode and realization, there is one more restriction: body handle should have the same return type as 'init'
>> The iterations handle must accept the same parameter types as init but return an int.
According to given 'lambdaman' example, 'iterations' could have no parameters.
+ It is hard to deduce resulting handle parameter list in the case of absent 'init' function. The situation is the same as inJDK-8150964 comment
It looks a little bit unclear, because there is no 'number' arguments in method definition. I suppose it would be better to mention that number of iteration is specified by given method handle invocation result (first arg). Actually, it is mentioned in 'parameters' section, but it is a little bit unclear in description. This part of description is really clear in the countedLoop(MH, MH, MH, MH)
>> The loop counter is an int initialized from the iterations handle evaluation result.
This sentence differs from pseudocode, because loop counter in pseudcode is initialized to 0. It could lead to misunderstanding. Moreover if we are talking about initialization value it would be good to note that the counter is incremented (or decremented) per 1 after each loop step. This part of description is really clear in the countedLoop(MH, MH, MH, MH)
>> The iterations handle must accept the same parameter types as init but return an int
I suppose it would be good to mention that 'iterations' shouldn't be null, because we can't talk about 'null' return value. According to realization, iterations = null leads to message "java.lang.IllegalArgumentException: found non-effectively identical parameter type lists" which is not so easy to decode in terms of countedLoop.
>> The counter is passed to the body function, so that must accept an initial int argument.
The second part looks unclear. Is there typo?
>> The result of the loop execution is the final value of the additional local state.
'Additional state' is defined in 'init' definition (at the end of documentation). At this point it is hard to understand what does it mean. And maybe it would be better to change 'result of loop execution' to 'result of created method handle invocation' or something like this. There is small ambiguity (loop method vs loop result structure). This part of description is really clear in the countedLoop(MH, MH, MH, MH)
>> The body handle must accept the same parameter types as well, preceded by an int parameter for the counter, and a parameter of the same type as init's result.
It would be good to add information about body return type. According to MethodHandles.loop(...), pseudocode and realization, there is one more restriction: body handle should have the same return type as 'init'
>> The iterations handle must accept the same parameter types as init but return an int.
According to given 'lambdaman' example, 'iterations' could have no parameters.
+ It is hard to deduce resulting handle parameter list in the case of absent 'init' function. The situation is the same as in
Attachments
Issue Links
- relates to
-
JDK-8153637 MethodHandles.countedLoop/3 initialises loop counter to 1 instead of 0
-
- Closed
-
-
-
- Closed
-
-
-
- Resolved
-