The following methods should be removed from ConstantReflectionProvider:
- readConstantArrayElement
- readConstantArrayElementForOffset
- readConstantFieldValue
- readStableFieldValue
These methods contain a lot of logic that clearly belongs in the compiler, not in the VM. Different compilers might even want to implement this logic differently (see e.g.JDK-8154765).
The logic in these methods can be easily implemented using the remaining methods.
- readConstantArrayElement
- readConstantArrayElementForOffset
- readConstantFieldValue
- readStableFieldValue
These methods contain a lot of logic that clearly belongs in the compiler, not in the VM. Different compilers might even want to implement this logic differently (see e.g.
The logic in these methods can be easily implemented using the remaining methods.