P2
In onError method, javadoc states "
Notifies an I/O or protocol error has occurred on the WebSocket.
The onError method does not correspond to any message from the WebSocket Protocol. It is a synthetic event. onError is the last invocation on the Listener. It is invoked at most once but after onOpen. If an exception is thrown from this method, it is ignored.
The WebSocket Protocol requires some errors occurs in the incoming destination must be fatal to the connection. In such cases the implementation takes care of closing the WebSocket. By the time onError is invoked, no more messages can be sent on this WebSocket.
"
And, in onText method, it state "
If an exception is thrown from this method or the returned CompletionStage completes exceptionally, then onError will be invoked with the exception."
It looks a bit controversy in the docs and behaviors:
Please consider:
1. if there is any runtime exception thrown in onText, should it be treated as "an I/O or protocol error" as documented in onError? I really doubt this.
2. in further, are the onXXX methods the only source of exception going into onError? It looks for me exception in such onXXX are actually most probably not "an I/O or protocol error"
3. What does "no more messages can be sent on this WebSocket." mean? If it is considered to throw any exception such as IllegalStateException, it should be documented in the WebSocket.sendXXX() methods.
4. I attached a new test for #2. It indicates message actually can be sent after on Error. Checked the server peer that the message was indeed sent to server.
These are several different but related problems. Please evaluate.
Notifies an I/O or protocol error has occurred on the WebSocket.
The onError method does not correspond to any message from the WebSocket Protocol. It is a synthetic event. onError is the last invocation on the Listener. It is invoked at most once but after onOpen. If an exception is thrown from this method, it is ignored.
The WebSocket Protocol requires some errors occurs in the incoming destination must be fatal to the connection. In such cases the implementation takes care of closing the WebSocket. By the time onError is invoked, no more messages can be sent on this WebSocket.
"
And, in onText method, it state "
If an exception is thrown from this method or the returned CompletionStage completes exceptionally, then onError will be invoked with the exception."
It looks a bit controversy in the docs and behaviors:
Please consider:
1. if there is any runtime exception thrown in onText, should it be treated as "an I/O or protocol error" as documented in onError? I really doubt this.
2. in further, are the onXXX methods the only source of exception going into onError? It looks for me exception in such onXXX are actually most probably not "an I/O or protocol error"
3. What does "no more messages can be sent on this WebSocket." mean? If it is considered to throw any exception such as IllegalStateException, it should be documented in the WebSocket.sendXXX() methods.
4. I attached a new test for #2. It indicates message actually can be sent after on Error. Checked the server peer that the message was indeed sent to server.
These are several different but related problems. Please evaluate.