Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8162413

tighten safety check for .m4 files newer than generated-configure.sh

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Cannot Reproduce
    • Icon: P4 P4
    • 9
    • 9
    • infrastructure
    • generic
    • generic

      The push for 8160873 touched a .m4 file in common/autoconf/ [1] but did not update the generated-configure.sh files. This was corrected in 8162409.

      The check in make/Init.gmk (see below) did not fire. Need to investigate why and tighten up the check.


      cat -n make/Init.gmk| less
       [...]
         138 # The spec files depend on the autoconf source code. This check makes sure
         139 # the configuration is up to date after changes to configure.
         140 CUSTOM_CONFIG_DIR ?= $(topdir)/closed/autoconf
         141
         142 $(SPECS): $(wildcard $(topdir)/common/autoconf/*) $(wildcard $(CUSTOM_CONFIG_DIR)/*)
         143 ifeq ($(CONF_CHECK), fail)
         144 @echo "Error: The configuration is not up to date for '$(lastword $(subst /, , $(dir $@)))'."
         145 $(call PrintConfCheckFailed)
         146 @exit 2
         147 else ifeq ($(CONF_CHECK), auto)
         148 @echo "Note: The configuration is not up to date for '$(lastword $(subst /, , $(dir $@)))'."
         149 @( cd $(topdir) && \
         150 $(MAKE) $(MFLAGS) $(MAKE_LOG_FLAGS) -r -R -f $(topdir)/make/Init.gmk \
         151 SPEC=$@ HAS_SPEC=true ACTUAL_TOPDIR=$(topdir) \
         152 reconfigure )
         153 else ifeq ($(CONF_CHECK), ignore)
         154 # Do nothing
         155 endif


      [1] http://hg.openjdk.java.net/jdk9/dev/rev/a3f2a1723e75

            Unassigned Unassigned
            tbell Tim Bell
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: