Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8179086

java.time.temporal.ValueRange has poor hashCode()

    XMLWordPrintable

Details

    • b06
    • Not verified

    Backports

      Description

        The hash code is currently implemented as
        {code}
            public int hashCode() {
                long hash = minSmallest + minLargest << 16 + minLargest >> 48 + maxSmallest << 32 +
                    maxSmallest >> 32 + maxLargest << 48 + maxLargest >> 16;
                return (int) (hash ^ (hash >>> 32));
            }
        {code}

        Since addition has higher precedence, the hash value is almost always is zero.
        (E.g. >> (32 + maxLargest) swaps away at least half of all the bits).

        The fix is to add some parentheses.

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8179093 java.time.temporal.ValueRange has poor hashCode()

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8188635 java.time.temporal.ValueRange has poor hashCode()

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8190637 java.time.temporal.ValueRange has poor hashCode()

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8198131 java.time.temporal.ValueRange has poor hashCode()

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8179092 java.time.temporal.ValueRange has poor hashCode()

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Closed
            links to

            Web Link Approval to backport to 8u

            Web Link Review

            Activity

              People

                igerasim Ivan Gerasimov
                igerasim Ivan Gerasimov
                Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: