Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8180437

Remaining renames of CAS misnomer "swap" => "set"

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: P4 P4
    • 10
    • 9
    • core-libs
    • None
    • b33

      We tried to rename all "compare-and-swap" to "compare-and-set", but some remain. We should change the one occurrence in VarHandle's class javadoc. Can we rename AccessType.COMPARE_AND_SWAP before jdk9 release?

      ./java/lang/invoke/VarHandle.java:49: * read/write access, and compare-and-swap.
      ./java/lang/invoke/VarHandle.java:1518: COMPARE_AND_SWAP(boolean.class),
      ./java/lang/invoke/VarHandle.java:1544: case COMPARE_AND_SWAP:
      ./java/lang/invoke/VarHandle.java:1641: COMPARE_AND_SET("compareAndSet", AccessType.COMPARE_AND_SWAP),
      ./java/lang/invoke/VarHandle.java:1665: WEAK_COMPARE_AND_SET_PLAIN("weakCompareAndSetPlain", AccessType.COMPARE_AND_SWAP),
      ./java/lang/invoke/VarHandle.java:1671: WEAK_COMPARE_AND_SET("weakCompareAndSet", AccessType.COMPARE_AND_SWAP),
      ./java/lang/invoke/VarHandle.java:1677: WEAK_COMPARE_AND_SET_ACQUIRE("weakCompareAndSetAcquire", AccessType.COMPARE_AND_SWAP),
      ./java/lang/invoke/VarHandle.java:1683: WEAK_COMPARE_AND_SET_RELEASE("weakCompareAndSetRelease", AccessType.COMPARE_AND_SWAP),
      ./java/lang/invoke/VarForm.java:74: methodType_table[VarHandle.AccessType.COMPARE_AND_SWAP.ordinal()] =
      ./java/lang/invoke/VarHandles.java:316:// boolean compareAndSwap(Object actualValue, Object expectedValue);
      ./jdk/internal/misc/JavaLangAccess.java:57: * Compare-And-Swap the AnnotationType instance corresponding to this class.

            psandoz Paul Sandoz
            martin Martin Buchholz
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: