Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8182719

Make obsolete VM options for shared region size control

XMLWordPrintable

    • Icon: CSR CSR
    • Resolution: Approved
    • Icon: P3 P3
    • 10
    • hotspot
    • behavioral
    • minimal
    • add/remove/modify command line option
    • JDK

      Summary

      Since JDK-8072061 (Automatically determine optimal sizes for the CDS regions) is integrated, the following 4 options are no longer necessary, and they are no longer used by the VM anymore. Hence, these options should be made obsolete:

      • SharedReadWriteSize
      • SharedReadOnlySize
      • SharedMiscDataSize
      • SharedMiscCodeSize

      Problem

      Unused VM arguments should be made obsolete.

      Solution

      Mark these options as obsolete in JDK 10.

      Specification

      diff -r 6126617b8508 src/hotspot/share/runtime/arguments.cpp
      --- a/src/hotspot/share/runtime/arguments.cpp   Sat Oct 21 15:15:46 2017 -0700
      +++ b/src/hotspot/share/runtime/arguments.cpp   Thu Oct 26 10:50:30 2017 -0700
      @@ -395,6 +395,10 @@
         { "MinSleepInterval",              JDK_Version::jdk(9),      JDK_Version::jdk(10), JDK_Version::jdk(11) },
         { "PermSize",                      JDK_Version::undefined(), JDK_Version::jdk(8),  JDK_Version::undefined() },
         { "MaxPermSize",                   JDK_Version::undefined(), JDK_Version::jdk(8),  JDK_Version::undefined() },
      +  { "SharedReadWriteSize",           JDK_Version::undefined(), JDK_Version::jdk(10), JDK_Version::undefined() },
      +  { "SharedReadOnlySize",            JDK_Version::undefined(), JDK_Version::jdk(10), JDK_Version::undefined() },
      +  { "SharedMiscDataSize",            JDK_Version::undefined(), JDK_Version::jdk(10), JDK_Version::undefined() },
      +  { "SharedMiscCodeSize",            JDK_Version::undefined(), JDK_Version::jdk(10), JDK_Version::undefined() },
      
       #ifdef TEST_VERIFY_SPECIAL_JVM_FLAGS
         { "dep > obs",                    JDK_Version::jdk(9), JDK_Version::jdk(8), JDK_Version::undefined() },
      
      
      diff -r 6126617b8508 src/hotspot/share/runtime/globals.hpp
      --- a/src/hotspot/share/runtime/globals.hpp Sat Oct 21 15:15:46 2017 -0700
      +++ b/src/hotspot/share/runtime/globals.hpp Thu Oct 26 10:50:30 2017 -0700
      @@ -3907,18 +3907,6 @@
                 "If PrintSharedArchiveAndExit is true, also print the shared "    \
                 "dictionary")                                                     \
                                                                                   \
      -  product(size_t, SharedReadWriteSize, 0,                                   \
      -          "Deprecated")                                                     \
      -                                                                            \
      -  product(size_t, SharedReadOnlySize, 0,                                    \
      -          "Deprecated")                                                     \
      -                                                                            \
      -  product(size_t, SharedMiscDataSize,  0,                                   \
      -          "Deprecated")                                                     \
      -                                                                            \
      -  product(size_t, SharedMiscCodeSize,  0,                                   \
      -          "Deprecated")                                                     \
      -                                                                            \
         product(size_t, SharedBaseAddress, LP64_ONLY(32*G)                        \
                 NOT_LP64(LINUX_ONLY(2*G) NOT_LINUX(0)),                           \
                 "Address to allocate shared memory region for class data")        \

            acorn Karen Kinnear (Inactive)
            iklam Ioi Lam
            Karen Kinnear (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: