Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8183288

Enable diagnostic code in release builds to eliminate optimized builds

XMLWordPrintable

    • Icon: Enhancement Enhancement
    • Resolution: Unresolved
    • Icon: P3 P3
    • tbd
    • 10, 11, 12
    • hotspot

      [~vlivanov] says: I always use optimized JVM in release builds for local development. There're lots of non-product code in C2 which is crucial for diagnostic purposes.
      8:56 AM
      e.g. IdealGraphVisualizer doesn't work with release binaries.

      Enable these features in release builds so that the optimized target can be removed.

      [~kvn] says: Hmm. I like Stefan's idea, but changing ifdef will not help code from rotting.
      4:10 PM
      Using explicit name like #if INCLUDE_STATISTIC_COUNTERS is much better than current #ifndef PRODUCT
      4:11 PM
      The only concern I have is it may not be only statistic code
      4:15 PM
      There should be no performance impact if the feature is off by default. As with non_product we build it ourself when we need it. You don't need it in release build.

            kvn Vladimir Kozlov
            coleenp Coleen Phillimore
            Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

              Created:
              Updated: