Asserts against MinObjectAlignment should avoid integer division

XMLWordPrintable

    • Type: Enhancement
    • Resolution: Fixed
    • Priority: P4
    • 10
    • Affects Version/s: 10
    • Component/s: hotspot
    • None
    • b21

      fastdebug builds performance is important to minimize testing time. In GC tests, we have a big hotspot at this line in oop::size_given_klass():
        assert(s % MinObjAlignment == 0, "Oop size is not properly aligned: %d", s);

      The hotspot is because of the integer division. Alas, the divisor is not known at compile time, because it can be set from the JVM command line, so compiler cannot optimize it. There is an easy fix, use the MinObjectAlignmentMask to assert:
       http://cr.openjdk.java.net/~shade/8184753/webrev.01

            Assignee:
            Aleksey Shipilev
            Reporter:
            Aleksey Shipilev
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: