-
Sub-task
-
Resolution: Fixed
-
P4
-
None
-
None
-
b25
samples/java_completion.js and samples/disassemble.js seems broken.
Beow are quick observations from sundar:
samples/java_completion.js : it has to call continuation method - it used to be a property, API changed
diff -r bece58f76216 samples/java_completion.js
--- a/samples/java_completion.js Thu Jul 20 21:12:24 2017 +0000
+++ b/samples/java_completion.js Wed Aug 09 08:37:49 2017 +0530
@@ -38,4 +38,4 @@
var analysis = repl.sourceCodeAnalysis()
var code = "System."
var suggestions = analysis.completionSuggestions(code, code.length, [0])
-suggestions.forEach(function(s) print(s.continuation))
+suggestions.forEach(s => print(s.continuation()))
disassemble.js sample should be removed. It does not work with jdk9's modular system
Beow are quick observations from sundar:
samples/java_completion.js : it has to call continuation method - it used to be a property, API changed
diff -r bece58f76216 samples/java_completion.js
--- a/samples/java_completion.js Thu Jul 20 21:12:24 2017 +0000
+++ b/samples/java_completion.js Wed Aug 09 08:37:49 2017 +0530
@@ -38,4 +38,4 @@
var analysis = repl.sourceCodeAnalysis()
var code = "System."
var suggestions = analysis.completionSuggestions(code, code.length, [0])
-suggestions.forEach(function(s) print(s.continuation))
+suggestions.forEach(s => print(s.continuation()))
disassemble.js sample should be removed. It does not work with jdk9's modular system