Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8186089

Move Arena to its own header file

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • P4
    • 10
    • 10
    • hotspot
    • None
    • b21

    Description

      The allocation.hpp header file has the class definition for Chunk and Arena. allocation.hpp is included everywhere forcing everything Chunk and Arena need to be included everywhere too. This doesn't cause circular dependencies now but may if header files are moved around.

      Also, finding class Arena in the file arena.hpp seems really nice.

      vmStructs.cpp has field offsets for class Chunk (there are tons of various Chunk classes), but the SA doesn't use Chunk or Arena. These offset macros should be removed also so that Chunk can be included in the implementation rather than definition file for Arena.

      This over inclusion was noticed when working on the GC interface and other metaprogramming support for atomics and order access so should be cleaned up in 10.

      Attachments

        Activity

          People

            hseigel Harold Seigel (Inactive)
            coleenp Coleen Phillimore
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: