Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8191227

Unsafe handle resolution in ConstantOopWriteValue::write_on() / print_on() and LIR_Assembler::jobject2reg()

    XMLWordPrintable

Details

    • b36

    Backports

      Description

        There's an assert in ConstantOopWriteValue::write_on() which does JNIHandles::resolve(). The problem is current thread is compiler thread and it isn't in VM (but in native) at that moment. So, it's unsafe to resolve a handle and access the naked oop.

        void ConstantOopWriteValue::write_on(DebugInfoWriteStream* stream) {
          assert(JNIHandles::resolve(value()) == NULL ||
                 Universe::heap()->is_in_reserved(JNIHandles::resolve(value())),
                 "Should be in heap");
          stream->write_int(CONSTANT_OOP_CODE);
          stream->write_handle(value());
        }

        Original report:
        http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2017-November/027546.html

        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8240093 Unsafe handle resolution in ConstantOopWriteValue::write_on() / print_on() and LIR_Assembler::jobject2reg()

            • P3 - Major loss of function.
            • Resolved
            blocks

            Enhancement - null JDK-8167372 Add code to check for getting oops while thread is in native

            • P3 - Major loss of function.
            • Resolved
            relates to

            Bug - A problem which impairs or prevents the functions of the product. JDK-8193699 AArch64: Fails to build after 8167372

            • P1 - Blocks development and/or testing work, production could not run.
            • Closed

            Activity

              People

                rraghavan Rahul Raghavan
                vlivanov Vladimir Ivanov
                Votes:
                0 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: