Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8191995

Regression: DatePicker must commit on focusLost

    XMLWordPrintable

Details

    Description

      had been fixed in JDK-8136838 and broken with fixing JDK-8150946

      The technical reason is the change in ComboBoxPopupControl in the latter, which removes the code that had been added in the former:

      +++ b/modules/controls/src/main/java/javafx/scene/control/skin/ComboBoxPopupControl.java Fri Jun 17 12:47:34 2016 +1200

      @@ -138,11 +138,6 @@

                   if (getEditor() != null) {

                       // Fix for the regression noted in a comment in RT-29885.

                       ((FakeFocusTextField)textField).setFakeFocus(hasFocus);

      -

      - // JDK-8120120 (aka RT-21454) and JDK-8136838

      - if (!hasFocus) {

      - setTextFromTextFieldIntoComboBoxValue();

      - }

                   }

               });

      The deeper reason is the oversight to not add commit/cancel semantics to the DatePicker - had not explicitly been mentioned in JDK-8150946 ...

      Attachments

        Issue Links

          csr for

          CSR - null JDK-8277782 Regression: DatePicker must commit on focusLost

          • P3 - Major loss of function.
          • Closed
          duplicates

          Bug - A problem which impairs or prevents the functions of the product. JDK-8254368 DatePicker - Not Committing Value on Focus Loss

          • P3 - Major loss of function.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. JDK-8151129 Editable ComboBox value update on focus lost is too late

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. JDK-8136838 [ComboBox, DatePicker] Value doesn't update when focus is lost

          • P3 - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JDK-8303478 DatePicker throws uncatchable exception on tab out from garbled text

          • P3 - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JDK-8150946 Editable ComboBox / Spinner controls need uniform 'commit on focus lost' semantics

          • P4 - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          links to

          Commit Commit openjdk/jfx/6fd4ab61

          Review Review openjdk/jfx/679

          Activity

            People

              mhanl Marius Hanl
              fastegal Jeanette Winzenburg
              Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: