Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8193386

CompressedClassSize too large with MaxMetaspace

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • P3
    • 10
    • 8, 10
    • hotspot
    • None
    • b37

    Backports

      Description

        > Hi Man,
        >
        > 2017-11-10 11:31 GMT+09:00 Man Cao <manc at google.com>:
        > > Hi Yasumasa,
        > >
        > > I'm looking at if this patch can fix the original issue with hsperfdata
        > > counters sun_gc_metaspace_maxCapacity and
        > > sun_gc_compressedclassspace_maxCapacity being too large when user has
        > set
        > > -XX:MaxMetaspaceSize=100m or some value less than 1GB. However, it does
        > not,
        > > these counters still reports around 1GB if MaxMetaspaceSize is less than
        > > 1GB.
        > >
        > > The reason is that the code added in this patch to
        > > Metaspace::ergo_initialize() is AFTER the two lines:
        > >
        > > CompressedClassSpaceSize =
        > > align_size_down_bounded(CompressedClassSpaceSize, _reserve_alignment);
        > > set_compressed_class_space_size(CompressedClassSpaceSize);
        > >
        > > So set_compressed_class_space_size() still gets the old value of
        > > CompressedClassSpaceSize that is too large, making the reserved size of
        > > metaspace too large.
        > >
        > > Should these two lines be moved after the code added in this patch?
        >
        > I agree with you.
        > Can you send review request for it? According to OCA signatories [1],
        > Google signs OCA, so I think you can contribute it to OpenJDK.
        >
        > I can file this to JBS, and create webrev and changest. But I cannot
        > push it to jdk/hs repo. So you need to find a sponsor.
        > I'm a reviewer of OpenJDK. So I can +1 to your change when you send
        > review request.
        >
        >
        > Thanks,
        >
        > Yasumasa

        Attachments

          Issue Links

            Activity

              People

                coleenp Coleen Phillimore
                coleenp Coleen Phillimore
                Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: