Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8195797

Obsolete the VM option UseUTCFileTimestamp

    XMLWordPrintable

Details

    • CSR
    • Resolution: Approved
    • P3
    • 11
    • hotspot
    • None
    • behavioral
    • minimal
    • Hide
      Except for this CSR and related bug, there isn't any bug filed regarding this option.
      Also, there's no test cases using this option.
      Show
      Except for this CSR and related bug, there isn't any bug filed regarding this option. Also, there's no test cases using this option.
    • add/remove/modify command line option
    • JDK

    Description

      Summary

      Obsolete the VM option UseUTCFileTimestamp.

      Problem

      The UseUTCFileTimestamp is a VM option for the windows platform. It was introduced for fixing JDK-6539723. After the fix for JDK-8188122, the option is no longer used. Therefore, the UseUTCFileTimestamp VM option should be made obsolete.

      Solution

      This is a windows-only vm option. So the option needs to be removed from the global_windows.hpp. The option also needs to be added to the obsolete section of the special_vm_flags table in arguments.cpp.

      Specification

          $ hg diff globals_windows.hpp
      diff --git a/src/hotspot/os/windows/globals_windows.hpp b/src/hotspot/os/windows/globals_windows.hpp
      --- a/src/hotspot/os/windows/globals_windows.hpp
      +++ b/src/hotspot/os/windows/globals_windows.hpp
      @@ -37,10 +37,7 @@
                                notproduct, \
                                range, \
                                constraint, \
      -                         writeable) \
      -                                                                         \
      -  product(bool, UseUTCFileTimestamp, true,                               \
      -          "Adjust the timestamp returned from stat() to be UTC")
      +                         writeable)
      
      
       //    
          diff --git a/src/hotspot/share/runtime/arguments.cpp b/src/hotspot/share/runtime/arguments.cpp
          --- a/src/hotspot/share/runtime/arguments.cpp
          +++ b/src/hotspot/share/runtime/arguments.cpp
          @@ -530,6 +530,7 @@
             { "SharedReadOnlySize",            JDK_Version::undefined(), JDK_Version::jdk(10), JDK_Version::undefined() },
             { "SharedMiscDataSize",            JDK_Version::undefined(), JDK_Version::jdk(10), JDK_Version::undefined() },
             { "SharedMiscCodeSize",            JDK_Version::undefined(), JDK_Version::jdk(10), JDK_Version::undefined() },
          +  { "UseUTCFileTimestamp",           JDK_Version::undefined(), JDK_Version::jdk(11), JDK_Version::undefined() },
      
           #ifdef TEST_VERIFY_SPECIAL_JVM_FLAGS
             { "dep > obs",                    JDK_Version::jdk(9), JDK_Version::jdk(8), JDK_Version::undefined() },

      Attachments

        Issue Links

          Activity

            People

              ccheung Calvin Cheung
              ccheung Calvin Cheung
              Ioi Lam
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: