Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8196349

class _ValueObj should not be subclassed

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Not an Issue
    • Icon: P4 P4
    • 12
    • 9, 10, 11
    • hotspot
    • None
    • generic
    • generic

      Value object guidance is here:

      src/hotspot/share/memory/allocation.hpp:

      // Base class for objects used as value objects.
      // Calling new or delete will result in fatal error.
      //
      // Portability note: Certain compilers (e.g. gcc) will
      // always make classes bigger if it has a superclass, even
      // if the superclass does not have any virtual methods or
      // instance fields. The HotSpot implementation relies on this
      // not to happen. So never make a ValueObj class a direct subclass
      // of this object, but use the VALUE_OBJ_CLASS_SPEC class instead, e.g.,
      // like this:
      //
      // class A VALUE_OBJ_CLASS_SPEC {
      // ...
      // }
      //
      // With gcc and possible other compilers the VALUE_OBJ_CLASS_SPEC can
      // be defined as a an empty string "".
      //

      In particular this, this bit of guidance:

        So never make a ValueObj class a direct subclass of this object,
        but use the VALUE_OBJ_CLASS_SPEC class instead

      However, there is one direct subclass of _ValueObj:

      src/hotspot/share/runtime/vframeArray.hpp:

      // A vframeArrayElement is an element of a vframeArray. Each element
      // represent an interpreter frame which will eventually be created.

      class vframeArrayElement : public _ValueObj {

            coleenp Coleen Phillimore
            dcubed Daniel Daugherty
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: