Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8198287

Cleanup ElfFile usage in whitebox.cpp

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: P4 P4
    • 11
    • 11
    • hotspot
    • None
    • 11
    • b03

      Prior to JDK-8193373 whitebox.cpp had some elfFile usage that was only enabled on Linux:

      #ifdef LINUX
      #include "utilities/elfFile.hpp"

      // Checks that the library libfile has the noexecstack bit set.
      WB_ENTRY(jboolean, WB_CheckLibSpecifiesNoexecstack(JNIEnv* env, jobject o, jstring libfile))
        jboolean ret = false;
      #ifdef LINUX
      ...
      ret = (jboolean) ElfFile::specifies_noexecstack(lf);
      ...
      #endif
        return ret;
      WB_END

      But then JDK-8193373 added an unconditional

      #include "utilities/elfFile.hpp"

      which means there are two include statements for Linux.

            zgu Zhengyu Gu
            dholmes David Holmes
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: