-
Bug
-
Resolution: Fixed
-
P3
-
None
-
None
-
b05
We have a lot of code duplication in all our calls to SetupNativeCompilation. This patch introduces a pair of functions, SetupJdkLibrary and SetupJdkExecutable, which wraps SetupNativeCompilation and sets up typical default values for our JDK libraries.
The long-term idea here is that even more functionality (e.g. basic LDFLAGS and CFLAGS) should move into these two functions, but for simplicity, this patch just does the most basic cleanup.
Not all compilations were easily converted. Those were left behind at using SetupNativeCompilation, just as before. If possible, they should be fixed and converted at a later date.
The long-term idea here is that even more functionality (e.g. basic LDFLAGS and CFLAGS) should move into these two functions, but for simplicity, this patch just does the most basic cleanup.
Not all compilations were easily converted. Those were left behind at using SetupNativeCompilation, just as before. If possible, they should be fixed and converted at a later date.
- duplicates
-
JDK-8001936 build-infra: Simplify calls to SetupNativeCompilation in CompileNativeLibraries.gmk
- Closed
- relates to
-
JDK-8001934 build-infra: Unify all RC_FLAGS in CompileNativeLibraries.gmk
- Resolved