Uploaded image for project: 'JDK'
  1. JDK
  2. JDK-8200118

[TESTBUG] String concat tests should test toString() application order

    XMLWordPrintable

Details

    Backports

      Description

        This issue covers the potential issue with MH_* strategies in StringConcatFactory that may end up calling toString() on arguments in wrong order. Non MH-strategies appear fine. See the evidence in the wild here:
          https://www.guardsquare.com/en/blog/string-concatenation-java-9-conversion-confusion

        This issue adds the relevant test for String concatenation. JDK 10 fails this new test. JDK 11+ passes the test, because the actual bug is JDK-8194554, which is fixed. In other words, StringConcatFactory implementation is actually correct, and it expects filterArguments to run in the specified order. Selectively applying fix from JDK-8194554 to JDK 10 makes it pass.


        Attachments

          Issue Links

            backported by

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8202530 [TESTBUG] String concat tests should test toString() application order

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8202734 [TESTBUG] String concat tests should test toString() application order

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Backport - A issue that is required to port a Bug or Feature into another product release. This issue type is generally associated with the main Bug/Feature to represent each individual release of the port. JDK-8202807 [TESTBUG] String concat tests should test toString() application order

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved
            is blocked by

            Bug - A problem which impairs or prevents the functions of the product. JDK-8194554 filterArguments runs multiple filters in the wrong order

            • P3 - Major loss of function.
            • Resolved
            relates to

            Bug - A problem which impairs or prevents the functions of the product. JDK-8200241 [TESTBUG] java/lang/String/concat/ tests should not force source/target = 9 anymore

            • P4 - Minor loss of function, or other problem where easy workaround is present.
            • Resolved

            Activity

              People

                shade Aleksey Shipilev
                shade Aleksey Shipilev
                Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                  Created:
                  Updated:
                  Resolved: