-
Bug
-
Resolution: Fixed
-
P4
-
11, 12
As part of JDK-8200178, I was asked to file a bug detailing all "suspicious" code I found related to exported symbols. Here is the list for java.base. Note that "suspicious" might just be something I misunderstood, not a definite cause for action.
In libjava:
* throwFileNotFoundException, getLastErrorString, getErrorString should probably not be exported.
* winFileHandleOpen, handleLseek was flagged during review as suspicious.
* Java_java_io_FileOutputStream_close0() in FileOutputStream_md.c is probably unused.
In libnet:
* NET_Wait was flagged during review as suspicious. Should it really be exported?
* Multiple methods are named like exported symbols, but are not actually exported. Is this correct? The symbols are:
NET_GetError, NET_ThrowCurrent, NET_GetFileDescriptorID, NET_IsIPv4Mapped, NET_IPv4MappedToIPv4, NET_IsEqual, NET_IsZeroAddr.
In libnio:
* handleSocketError should most likely not be exported.
In libjava:
* throwFileNotFoundException, getLastErrorString, getErrorString should probably not be exported.
* winFileHandleOpen, handleLseek was flagged during review as suspicious.
* Java_java_io_FileOutputStream_close0() in FileOutputStream_md.c is probably unused.
In libnet:
* NET_Wait was flagged during review as suspicious. Should it really be exported?
* Multiple methods are named like exported symbols, but are not actually exported. Is this correct? The symbols are:
NET_GetError, NET_ThrowCurrent, NET_GetFileDescriptorID, NET_IsIPv4Mapped, NET_IPv4MappedToIPv4, NET_IsEqual, NET_IsZeroAddr.
In libnio:
* handleSocketError should most likely not be exported.
- is cloned by
-
JDK-8200249 Verify exported symbols in libjli
-
- Closed
-
- relates to
-
JDK-8200178 Remove mapfiles for JDK native libraries
-
- Resolved
-